-
Couldn't load subscription status.
- Fork 43
chore: Move dev extras to dependency-groups #71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: kramaranya <kramaranya15@gmail.com>
Pull Request Test Coverage Report for Build 17232046445Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 17208747046Details
💛 - Coveralls |
|
Thanks Anya! I think if we follow the proposal here #36 to publish |
Signed-off-by: kramaranya <kramaranya15@gmail.com>
Signed-off-by: Anya Kramar <kramaranya15@gmail.com>
We don't currently publish That said, have you seen other projects publishing packages with a master tag? I don't think PyPI supports mutable master or main tags. Instead, what we could do for the Kubeflow SDK is publish a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you're right, pypi.org doesn't support mutable versions like main/master/stable.
so I think for now our best option is to use dependency-groups let uv install it by default.
Signed-off-by: kramaranya <kramaranya15@gmail.com>
|
We may have to adjust the approach when there'll be multiple release branches maintained but we are not there yet. /lgtm Thanks @kramaranya! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this @kramaranya!
/lgtm
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andreyvelich The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* chore: Move dev extras to dependency-groups Signed-off-by: kramaranya <kramaranya15@gmail.com> * update uv sync command Signed-off-by: kramaranya <kramaranya15@gmail.com> * add development build to CONTRIBUTING Signed-off-by: kramaranya <kramaranya15@gmail.com> --------- Signed-off-by: kramaranya <kramaranya15@gmail.com> Signed-off-by: Anya Kramar <kramaranya15@gmail.com>
What this PR does / why we need it:
PyPi doesn't allow to use git dependency in extras when publishing to PyPI. I've moved dev extras to dependency-groups
Which issue(s) this PR fixes:
Fixes #70
Checklist:
/assign @andreyvelich @astefanutti @Electronic-Waste