Skip to content

Conversation

@kramaranya
Copy link
Contributor

What this PR does / why we need it:
PyPi doesn't allow to use git dependency in extras when publishing to PyPI. I've moved dev extras to dependency-groups

Which issue(s) this PR fixes:

Fixes #70

Checklist:

  • Docs included if any changes are user facing

/assign @andreyvelich @astefanutti @Electronic-Waste

Signed-off-by: kramaranya <kramaranya15@gmail.com>
@coveralls
Copy link

coveralls commented Aug 25, 2025

Pull Request Test Coverage Report for Build 17232046445

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage remained the same at 65.033%

Files with Coverage Reduction New Missed Lines %
kubeflow/trainer/backends/kubernetes/backend.py 1 70.26%
kubeflow/trainer/utils/utils.py 1 58.9%
Totals Coverage Status
Change from base Build 17222665539: 0.0%
Covered Lines: 292
Relevant Lines: 449

💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 17208747046

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 64.877%

Totals Coverage Status
Change from base Build 17059769083: 0.3%
Covered Lines: 290
Relevant Lines: 447

💛 - Coveralls

@szaher
Copy link
Member

szaher commented Aug 25, 2025

Thanks Anya!

I think if we follow the proposal here #36 to publish kubeflow-trainer-api, we won't have problems publishing kubeflow sdk to pypi.org as we can easily replace the git+https with a python wheel from pypi.org with master tag instead of specific version which will always give us the latest code.

Signed-off-by: kramaranya <kramaranya15@gmail.com>
@google-oss-prow google-oss-prow bot added size/M and removed size/S labels Aug 25, 2025
Signed-off-by: Anya Kramar <kramaranya15@gmail.com>
@kramaranya
Copy link
Contributor Author

I think if we follow the proposal here #36 to publish kubeflow-trainer-api, we won't have problems publishing kubeflow sdk to pypi.org as we can easily replace the git+https with a python wheel from pypi.org with master tag instead of specific version which will always give us the latest code.

We don't currently publish kubeflow-trainer-api with a master tag to PyPI. If we decide to do something like that, it would be part of kubeflow/trainer#2155. For now, we can move this to dependency-groups for dev deps

That said, have you seen other projects publishing packages with a master tag? I don't think PyPI supports mutable master or main tags.

Instead, what we could do for the Kubeflow SDK is publish a kubeflow-nightly version.
Any thoughts on that @szaher @andreyvelich?

Copy link
Member

@szaher szaher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you're right, pypi.org doesn't support mutable versions like main/master/stable.

so I think for now our best option is to use dependency-groups let uv install it by default.

Signed-off-by: kramaranya <kramaranya15@gmail.com>
@google-oss-prow google-oss-prow bot added size/S and removed size/M labels Aug 26, 2025
@astefanutti
Copy link
Contributor

We may have to adjust the approach when there'll be multiple release branches maintained but we are not there yet.

/lgtm

Thanks @kramaranya!

@google-oss-prow google-oss-prow bot added the lgtm label Aug 26, 2025
Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this @kramaranya!
/lgtm
/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit e1b6819 into kubeflow:main Aug 26, 2025
9 checks passed
@google-oss-prow google-oss-prow bot added this to the v0.1 milestone Aug 26, 2025
@kramaranya kramaranya mentioned this pull request Aug 26, 2025
12 tasks
accorvin pushed a commit to opendatahub-io/kubeflow-sdk that referenced this pull request Oct 8, 2025
* chore: Move dev extras to dependency-groups

Signed-off-by: kramaranya <kramaranya15@gmail.com>

* update uv sync command

Signed-off-by: kramaranya <kramaranya15@gmail.com>

* add development build to CONTRIBUTING

Signed-off-by: kramaranya <kramaranya15@gmail.com>

---------

Signed-off-by: kramaranya <kramaranya15@gmail.com>
Signed-off-by: Anya Kramar <kramaranya15@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PyPI Publishing Blocked by Git Dependencies

6 participants