-
Notifications
You must be signed in to change notification settings - Fork 41
add e2e notebook tests #27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 4 commits
93a21d9
3a9ea54
8bc9499
bce90c0
d7fbbed
23a8095
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,71 @@ | ||
| name: E2E Test | ||
|
|
||
| on: | ||
| pull_request | ||
|
|
||
| jobs: | ||
| e2e-test: | ||
| name: E2E Test | ||
| runs-on: | ||
| labels: ubuntu-latest-16-cores | ||
briangallagher marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should we start adding the Trainer version in the matrix right now? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Given that the sdk is compatible with v2 of the trainer and it's not yet released, I'm not sure what we would put here or how it would work. I think we should address it in a future PR, wdyt? Related maybe, we should finalise the version control and compatibility strategy There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Right, we could either put There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. added master ref |
||
| kubernetes-version: ["1.30.0", "1.31.0", "1.32.3", "1.33.2"] | ||
briangallagher marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
| steps: | ||
| - name: Checkout Kubeflow SDK repository | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Checkout Kubeflow Trainer repo for Go version | ||
briangallagher marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| uses: actions/checkout@v4 | ||
| with: | ||
| repository: kubeflow/trainer | ||
| ref: master | ||
| path: trainer | ||
|
|
||
| - name: Setup Python | ||
| uses: actions/setup-python@v5 | ||
| with: | ||
| python-version: 3.11 | ||
|
|
||
| - name: Install Python dependencies | ||
| run: | | ||
| echo "Installing Papermill and Jupyter" | ||
| pip install papermill==2.6.0 jupyter==1.1.1 ipykernel==6.29.5 | ||
|
|
||
| echo "Installing Kubeflow SDK locally from ./python" | ||
| # This path (./python) is relative to the *main* repository checkout (kubeflow/sdk) | ||
| pip install ./python | ||
| working-directory: . # Ensure pip runs from the SDK repo root | ||
|
|
||
| - name: Setup cluster | ||
| run: | | ||
| cd ./trainer | ||
| make test-e2e-setup-cluster \ | ||
| K8S_VERSION=${{ matrix.kubernetes-version }} \ | ||
| working-directory: . # Execute make from the root of the SDK repo | ||
|
|
||
| - name: Run e2e test for example Notebooks | ||
| run: | | ||
| mkdir -p artifacts/notebooks # Create the output directory | ||
| cd ./trainer | ||
| # Execute make commands, passing notebook paths and output locations | ||
| make test-e2e-notebook \ | ||
| NOTEBOOK_INPUT=./examples/pytorch/image-classification/mnist.ipynb \ | ||
| NOTEBOOK_OUTPUT=../artifacts/notebooks/${{ matrix.kubernetes-version }}_mnist.ipynb \ | ||
| PAPERMILL_TIMEOUT=900 | ||
| make test-e2e-notebook \ | ||
| NOTEBOOK_INPUT=./examples/pytorch/question-answering/fine-tune-distilbert.ipynb \ | ||
| NOTEBOOK_OUTPUT=../artifacts/notebooks/${{ matrix.kubernetes-version }}_fine-tune-distilbert.ipynb \ | ||
| PAPERMILL_TIMEOUT=900 | ||
| working-directory: . # Execute make from the root of the SDK repo | ||
|
|
||
| - name: Upload Artifacts to GitHub | ||
| uses: actions/upload-artifact@v4 | ||
| if: always() # Ensure artifacts are uploaded even if previous steps fail | ||
| with: | ||
| name: ${{ matrix.kubernetes-version }} | ||
| path: ./artifacts/notebooks/* # Path relative to the workspace root | ||
| retention-days: 1 # | ||
Uh oh!
There was an error while loading. Please reload this page.