-
Notifications
You must be signed in to change notification settings - Fork 41
add e2e notebook tests #27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
google-oss-prow
merged 6 commits into
kubeflow:main
from
briangallagher:add-e2e-notebook-tests
Jul 17, 2025
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
93a21d9
add e2e ntoebook tests
briangallagher 3a9ea54
address comments in review for e2e test
briangallagher 8bc9499
addressing review comments
briangallagher bce90c0
running cluster setup and e2e tests from checked out trainer repo
briangallagher d7fbbed
update kubernetes-version support
briangallagher 23a8095
use oci gh arc runner for e2e test workflow
briangallagher File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,71 @@ | ||
| name: E2E Test | ||
|
|
||
| on: | ||
| pull_request | ||
|
|
||
| jobs: | ||
| e2e-test: | ||
| name: E2E Test | ||
| runs-on: oracle-vm-16cpu-64gb-x86-64 | ||
|
|
||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| kubernetes-version: ["1.29.14", "1.30.0", "1.31.0", "1.32.3"] | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can we drop support for Kubernetes v1.29 and add v1.33 ? |
||
| trainer-ref: ["master"] | ||
|
|
||
| steps: | ||
| - name: Checkout Kubeflow SDK repository | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Checkout Kubeflow Trainer repository | ||
| uses: actions/checkout@v4 | ||
| with: | ||
| repository: kubeflow/trainer | ||
| ref: ${{ matrix.trainer-ref }} | ||
| path: trainer | ||
|
|
||
| - name: Setup Python | ||
| uses: actions/setup-python@v5 | ||
| with: | ||
| python-version: 3.11 | ||
|
|
||
| - name: Install Python dependencies | ||
| run: | | ||
| echo "Installing Papermill and Jupyter" | ||
| pip install papermill==2.6.0 jupyter==1.1.1 ipykernel==6.29.5 | ||
| echo "Installing Kubeflow SDK locally from ./python" | ||
| # This path (./python) is relative to the *main* repository checkout (kubeflow/sdk) | ||
| pip install ./python | ||
| working-directory: . # Ensure pip runs from the SDK repo root | ||
|
|
||
| - name: Setup cluster | ||
| run: | | ||
| cd ./trainer | ||
| make test-e2e-setup-cluster \ | ||
| K8S_VERSION=${{ matrix.kubernetes-version }} \ | ||
| working-directory: . # Execute make from the root of the SDK repo | ||
|
|
||
| - name: Run e2e test for example Notebooks | ||
| run: | | ||
| mkdir -p artifacts/notebooks # Create the output directory | ||
| cd ./trainer | ||
| # Execute make commands, passing notebook paths and output locations | ||
| make test-e2e-notebook \ | ||
| NOTEBOOK_INPUT=./examples/pytorch/image-classification/mnist.ipynb \ | ||
| NOTEBOOK_OUTPUT=../artifacts/notebooks/${{ matrix.kubernetes-version }}_mnist.ipynb \ | ||
| PAPERMILL_TIMEOUT=900 | ||
| make test-e2e-notebook \ | ||
| NOTEBOOK_INPUT=./examples/pytorch/question-answering/fine-tune-distilbert.ipynb \ | ||
| NOTEBOOK_OUTPUT=../artifacts/notebooks/${{ matrix.kubernetes-version }}_fine-tune-distilbert.ipynb \ | ||
| PAPERMILL_TIMEOUT=900 | ||
| working-directory: . # Execute make from the root of the SDK repo | ||
|
|
||
| - name: Upload Artifacts to GitHub | ||
| uses: actions/upload-artifact@v4 | ||
| if: always() # Ensure artifacts are uploaded even if previous steps fail | ||
| with: | ||
| name: ${{ matrix.kubernetes-version }} | ||
| path: ./artifacts/notebooks/* # Path relative to the workspace root | ||
| retention-days: 1 # | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we start adding the Trainer version in the matrix right now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that the sdk is compatible with v2 of the trainer and it's not yet released, I'm not sure what we would put here or how it would work. I think we should address it in a future PR, wdyt? Related maybe, we should finalise the version control and compatibility strategy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, we could either put
masterthere right now, but addressing it in a future PR is perfectly fine too.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added master ref