Skip to content

Default to SeaweedFS instead of MinIO #3240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Sep 10, 2025
+23 −10
Merged

Default to SeaweedFS instead of MinIO #3240

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
68bdde1
use seaweedfs by default
akagami-harsh Sep 9, 2025
ec6ed71
fix unit test
akagami-harsh Sep 9, 2025
da6ca0a
rm redundant networkpolicy
akagami-harsh Sep 10, 2025
46b7a25
add back networkpolicy
akagami-harsh Sep 10, 2025
d14c7d1
add todo comment
akagami-harsh Sep 10, 2025
70bb210
sync seaweedfs manifests
akagami-harsh Sep 10, 2025
55f8942
fix typos
akagami-harsh Sep 10, 2025
9587f73
Update README.md
juliusvonkohout Sep 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion experimental/seaweedfs/base/seaweedfs/seaweedfs-networkpolicy.yaml
View file
Open in desktop
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can just delete the policy. We will anyway get it from common/networkpolicies by default.

Copy link
Contributor Author

@akagami-harsh akagami-harsh Sep 10, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test are failing cause when tests install pipelines form /experimental/seaweedfs/istio it dosent include networkpolicies from common folder. maybe we can keep the allow-same-namespace networkpolicy till the next kfp release, then kfp will have this networkpolicy by default

Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
apiVersion: networking.k8s.io/v1
kind: NetworkPolicy
metadata:
name: default-allow-same-namespace
name: default-allow-same-namespace-seaweedfs
namespace: kubeflow
spec:
podSelector: {}
Expand Down
Loading