Skip to content

Conversation

akagami-harsh
Copy link
Contributor

Pull Request Template for Kubeflow Manifests

✏️ Summary of Changes

Describe the changes you have made, including any refactoring or feature additions.

📦 Dependencies

List any dependencies or related PRs (e.g., "Depends on #123").

🐛 Related Issues

Link any issues that are resolved or affected by this PR.

✅ Contributor Checklist

  • I have tested these changes with kustomize. See Installation Prerequisites.
  • All commits are signed-off to satisfy the DCO check.
  • I have considered adding my company to the adopters page to support Kubeflow and help the community, since I expect help from the community for my issue (see 1. and 2.).

You can join the CNCF Slack and access our meetings at the Kubeflow Community website. Our channel on the CNCF Slack is here #kubeflow-platform.

Signed-off-by: Harshvir Potpose <hpotpose62@gmail.com>
Signed-off-by: Harshvir Potpose <hpotpose62@gmail.com>
@akagami-harsh
Copy link
Contributor Author

/retest

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can just delete the policy. We will anyway get it from common/networkpolicies by default.

Copy link
Contributor Author

@akagami-harsh akagami-harsh Sep 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test are failing cause when tests install pipelines form /experimental/seaweedfs/istio it dosent include networkpolicies from common folder. maybe we can keep the allow-same-namespace networkpolicy till the next kfp release, then kfp will have this networkpolicy by default

Signed-off-by: Harshvir Potpose <hpotpose62@gmail.com>
- ../common/kubeflow-roles/base
# Kubeflow Istio Resources
- ../common/istio/kubeflow-istio-resources/base
# Kubeflow Pipelines
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please comment it out as in the other PR. and add a TODO to reenable this after the next kfp release as in the other PR.

@juliusvonkohout
Copy link
Member

Please also check that it is really the same as we have in KFP for example we did some changes later on. We switched the pvc size to 20 GB and disabled pre allocation etc. It should be the same content as in the kfp repository.

Signed-off-by: Harshvir Potpose <hpotpose62@gmail.com>
Signed-off-by: Harshvir Potpose <hpotpose62@gmail.com>
Signed-off-by: Harshvir Potpose <hpotpose62@gmail.com>
akagami-harsh and others added 2 commits September 10, 2025 17:37
Signed-off-by: Harshvir Potpose <hpotpose62@gmail.com>
Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>
@juliusvonkohout
Copy link
Member

/lgtm
/approve
until we get a release from the KFP master branch which has the seaweedfs changes. Then we can remove it from experimental and adjust our tests.
@HumairAK we could also synchronize the KFP master branch if you think that it is stable enough.

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juliusvonkohout

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@juliusvonkohout juliusvonkohout mentioned this pull request Sep 10, 2025
3 tasks
@google-oss-prow google-oss-prow bot merged commit 03b070d into kubeflow:master Sep 10, 2025
8 checks passed
@akagami-harsh akagami-harsh deleted the defalut-seaweedfs branch September 10, 2025 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants