-
Notifications
You must be signed in to change notification settings - Fork 960
Fix PSS restricted warnings for kubeflow components #3050
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
testing CI here, if it works then i'll make separate PRs to upstream repos |
Thank you, please also leave this one here open as well :-) |
The |
update: we can fix this by using istio-cni istio/istio#35894 |
opened PR in respective upstream repos |
b6637d2
to
10179b5
Compare
1fc1a25
to
72c2dad
Compare
kubeflow/pipelines#11751 for KFP has been merged |
kubeflow/dashboard#87 for tracking in Kubeflow/ dashboard |
@akagami-harsh there is something you can fix directly in kubeflow / manifests overlays, not the upstream part.
|
opened a pr #3118 |
Please rebase to master to fix the conflict |
defacdd
to
6bb1d86
Compare
990e13a
to
489ea28
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This must happen in an overlay.in apps/kserve Kserve_kubeflow.yaml comes from upstream and should not be modified
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this can be removed sinc eit is already patched here https://github.com/kubeflow/manifests/blob/master/apps/kserve/kserve/kustomization.yaml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this patch still needed or can it be removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you fix this in another PR already?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, in this pr #3108
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this not yet upstream in KFP?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think i made a mistake here in this pr kubeflow/pipelines#11751 , accidentally modified this upstream argo deployment instead of adding a overlay. I'll create another pr in pipelines to fix this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this already upstream?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had created a PR in kubeflow/kubeflow for this, but it was closed since the code has been moved to a new repo, kubeflow/notebooks. So, I’ll need to create a PR there now.
Signed-off-by: Harshvir Potpose <hpotpose62@gmail.com>
Signed-off-by: Harshvir Potpose <hpotpose62@gmail.com>
Signed-off-by: Harshvir Potpose <hpotpose62@gmail.com>
Signed-off-by: Harshvir Potpose <hpotpose62@gmail.com>
Signed-off-by: Harshvir Potpose <hpotpose62@gmail.com>
Signed-off-by: Harshvir Potpose <hpotpose62@gmail.com>
Signed-off-by: Harshvir Potpose <hpotpose62@gmail.com>
Signed-off-by: Harshvir Potpose <hpotpose62@gmail.com>
Signed-off-by: Harshvir Potpose <hpotpose62@gmail.com>
489ea28
to
e004671
Compare
/retest please split this up into separate PRs that are easy and faster to merge. |
Pull Request Template for Kubeflow Manifests
✏️ Summary of Changes
📦 Dependencies
🐛 Related Issues
✅ Contributor Checklist