Skip to content

Use istio cni in pipelines gha #3128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 11, 2025
Merged

Use istio cni in pipelines gha #3128

merged 1 commit into from
May 11, 2025

Conversation

akagami-harsh
Copy link
Contributor

@akagami-harsh akagami-harsh commented May 11, 2025 •
edited
Loading

Pull Request Template for Kubeflow Manifests

✏️ Summary of Changes

  • use istio-cni in the pipelines gha

📦 Dependencies

List any dependencies or related PRs (e.g., "Depends on #123").

🐛 Related Issues

✅ Contributor Checklist

  • I have tested these changes with kustomize. See Installation Prerequisites.
  • All commits are signed-off to satisfy the DCO check.
  • I have considered adding my company to the adopters page to support Kubeflow and help the community, since I expect help from the community for my issue (see 1. and 2.).

You can join the CNCF Slack and access our meetings at the Kubeflow Community website. Our channel on the CNCF Slack is here #kubeflow-platform.

@juliusvonkohout
Copy link
Member

/lgtm
/approve

the pipeline test is still a bit unstable

@juliusvonkohout
Copy link
Member

Hhhm it seems that GHA does not like my commit

@juliusvonkohout
Copy link
Member

Maybe you can just squash all commits and sign again

@akagami-harsh
use istio cni
13fbea7 
Signed-off-by: Harshvir Potpose <hpotpose62@gmail.com>

Update pipeline_test.yaml

Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>

Update pipeline_run_from_notebook.yaml

Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>
@google-oss-prow google-oss-prow bot removed the lgtm label May 11, 2025
@akagami-harsh
Copy link
Contributor Author

akagami-harsh commented May 11, 2025 •
edited
Loading

pipelines V2 tests are failing, do we need to fix it?

@juliusvonkohout
Copy link
Member

pipelines V2 tests are failing, do we need to fix it?

That is something @kunal-511 is working on in another PR. The test is just not very stable

@juliusvonkohout
Copy link
Member

/retest

@juliusvonkohout
Copy link
Member

juliusvonkohout commented May 11, 2025 •
edited
Loading

See also #3129
Maybe you can help Kunal there.

@juliusvonkohout
Copy link
Member

/lgtm
/approve

@google-oss-prow google-oss-prow bot added the lgtm label May 11, 2025
@google-oss-prow Google OSS Prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juliusvonkohout

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 21ababc into kubeflow:master May 11, 2025
9 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliusvonkohout juliusvonkohout Awaiting requested review from juliusvonkohout

@kimwnasptd kimwnasptd Awaiting requested review from kimwnasptd

Assignees

@juliusvonkohout juliusvonkohout

Labels
approved lgtm size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akagami-harsh @juliusvonkohout