Skip to content

[SDK] fix issue with serialization of LoraConfig #2567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 11, 2025
+8 −3
Merged

[SDK] fix issue with serialization of LoraConfig #2567

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions sdk/python/v1beta1/kubeflow/katib/utils/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,8 +188,9 @@ def get_trial_substitutions_from_trainer(
if isinstance(parameters, TrainingArguments):
parameters_dict = parameters.to_dict()
else:
parameters_dict = parameters.__dict__

parameters_dict = (
parameters.to_dict() if hasattr(parameters, "to_dict") else vars(parameters)
)
for p_name, p_value in parameters_dict.items():
if not hasattr(parameters, p_name):
logger.warning(f"Training parameter {p_name} is not supported.")
Expand Down Expand Up @@ -218,7 +219,11 @@ def get_trial_substitutions_from_trainer(
if isinstance(parameters, TrainingArguments):
parameters = json.dumps(parameters.to_dict())
else:
parameters = json.dumps(parameters.__dict__, cls=SetEncoder)
parameters = (
json.dumps(parameters.to_dict(), cls=SetEncoder)
if hasattr(parameters, "to_dict")
else json.dumps(vars(parameters), cls=SetEncoder)
)

return parameters

Expand Down
Loading