[SDK] fix issue with serialization of LoraConfig #2567
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Sorry for the late review @Hexoplon!
overall lgtm.
/assign @helenxie-bit @Electronic-Waste
|
Thank you @andreyvelich, I have updated the code with your suggestions |
|
@Hexoplon Can you fix CI please ? |
Signed-off-by: Zackeus Bengtsson <github@zackeus.no>
Fixed now, all pre commit hooks are passing |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andreyvelich The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Improve JSON serialization to fix issue occuring when following https://www.kubeflow.org/docs/components/katib/user-guides/llm-hp-optimization/, among other guides. Currently, running the example code with the latest versions of katib sdk peft and transformers, would result in an error of
TypeError: Object of type LoraRuntimeConfig is not JSON serializable. Now, it will correctly use .to_dict when available, and dict otherwise for non TrainingArgument types