Skip to content

chore(otel-api): update api references for otel v1beta1 api #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 16, 2024

Conversation

kristofgyuracz
Copy link
Collaborator

No description provided.

Signed-off-by: Kristof Gyuracz <kristof.gyuracz@axoflow.com>
Signed-off-by: Kristof Gyuracz <kristof.gyuracz@axoflow.com>
Signed-off-by: Kristof Gyuracz <kristof.gyuracz@axoflow.com>
@kristofgyuracz kristofgyuracz force-pushed the api-update branch 2 times, most recently from 6689af3 to 54925f9 Compare July 15, 2024 12:02
@kristofgyuracz kristofgyuracz marked this pull request as ready for review July 15, 2024 12:06
Copy link
Member

@pepov pepov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would try to generate the json from yaml, to help with future updates (if that makes sense)

@kristofgyuracz kristofgyuracz marked this pull request as draft July 15, 2024 13:00
Signed-off-by: Kristof Gyuracz <kristof.gyuracz@axoflow.com>
@kristofgyuracz kristofgyuracz marked this pull request as ready for review July 16, 2024 12:11
Copy link
Collaborator

@OverOrion OverOrion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for this! 🎉

@kristofgyuracz
Copy link
Collaborator Author

I would try to generate the json from yaml, to help with future updates (if that makes sense)

Would not put effort into that, probably we could find a better way to do these tests, serialisation is not a concern in any other case.

@kristofgyuracz kristofgyuracz merged commit 97e87d8 into main Jul 16, 2024
12 checks passed
@kristofgyuracz kristofgyuracz deleted the api-update branch July 16, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants