Skip to content

Common - ArithTraits: moving from Kokkos to KokkosKernels #2771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Sep 30, 2025
Merged

Common - ArithTraits: moving from Kokkos to KokkosKernels #2771

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f486683
Common - ArithTraits: moving from Kokkos to KokkosKernels
lucbv Sep 15, 2025
bdef930
Applying change of namespace to library and tests
lucbv Sep 29, 2025
d90eff8
Trying to fix the issue with sycl...
lucbv Sep 29, 2025
f0c21ca
More fixes for std::complex<T>
lucbv Sep 29, 2025
b615b27
common: moving ArithTraits to KokkosKernels_ArithTraits.hpp
lucbv Sep 30, 2025
782b229
Updating header inclusion to use new KokkosKernels_ArithTraits.hpp
lucbv Sep 30, 2025
560e9d4
Applying clang-format
lucbv Sep 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions common/src/Kokkos_ArithTraits.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1093,14 +1093,12 @@ class ArithTraits<std::complex<RealFloatType>> {
} else {
KOKKOS_IF_ON_HOST((using std::isinf;))
KOKKOS_IF_ON_DEVICE((using sycl::isinf;))
return isinf(real(x)) || isinf(imag(x));
return isinf(std::real(x)) || isinf(std::imag(x));
}
}
#else
static bool isInf(const std::complex<RealFloatType>& x) {
KOKKOS_IF_ON_HOST((using std::isinf;))
KOKKOS_IF_ON_DEVICE((using Kokkos::isinf;))
return isinf(real(x)) || isinf(imag(x));
return std::isinf(std::real(x)) || std::isinf(std::imag(x));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why std::?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly I am not sure I understand how the hole thing works on device but if you look further down, real and imag function are implemented by call std::real and std::imag.
So for now it's not worse than it was and it allows to complete the scope I defined for this PR.
Of course these functions could easily cause problem down the line and opening an issue to work on it is appropriate.

}
#endif

Expand All @@ -1113,14 +1111,12 @@ class ArithTraits<std::complex<RealFloatType>> {
} else {
KOKKOS_IF_ON_HOST((using std::isnan;))
KOKKOS_IF_ON_DEVICE((using sycl::isnan;))
return isnan(real(x)) || isnan(imag(x));
return isnan(std::real(x)) || isnan(std::imag(x));
}
}
#else
static bool isNan(const std::complex<RealFloatType>& x) {
KOKKOS_IF_ON_HOST((using std::isnan;))
KOKKOS_IF_ON_DEVICE((using Kokkos::isnan;))
return isnan(real(x)) || isnan(imag(x));
return std::isnan(std::real(x)) || std::isnan(std::imag(x));
}
#endif
static mag_type abs(const std::complex<RealFloatType>& x) { return std::abs(x); }
Expand Down
Loading