Common - ArithTraits: moving from Kokkos to KokkosKernels #2771

lucbv · 2025-09-15T14:57:51Z

This simply moves the class to a new namespace to avoid having it in the Kokkos namespace.

dalg24

Any chance to deprecate the header as well and redirect to a new header with appropriate prefix?

dalg24 · 2025-09-15T16:03:09Z

common/src/Kokkos_ArithTraits.hpp

 namespace Details {
 template <typename T>
-using ArithTraits [[deprecated("Use Kokkos::ArithTraits instead")]] = ::Kokkos::ArithTraits<T>;
+using ArithTraits [[deprecated("Use KokkosKernels::ArithTraits instead")]] = ::KokkosKernels::ArithTraits<T>;


How long ago did you deprecate this alias?
Is removing it an option?

We are pretty close to 5.0.0, why would we do a backward breaking change against our policies at this point?

I am talking about the alias in Details:: that was already marked as deprecated

I understand and what I said above still stands, do we really need to be removed before 5.0.0? That's only a few months away...

What do you mean "before 5.0"?

I don't want to remove this until after the last release in the 4.7 series

4.7 was the last minor release in the 4.x series

Okay so not 4.7.2 right? straight to 5.0.0?

4.7.2 would come from 4.7.1 not develop

This simply moves the class to a new namespace to avoid having it in the Kokkos namespace. Signed-off-by: Luc Berger-Vergiat <lberge@sandia.gov>

Signed-off-by: Luc Berger-Vergiat <lberge@sandia.gov>

dalg24 · 2025-09-30T12:05:05Z

common/src/Kokkos_ArithTraits.hpp

-    KOKKOS_IF_ON_HOST((using std::isinf;))
-    KOKKOS_IF_ON_DEVICE((using Kokkos::isinf;))
-    return isinf(real(x)) || isinf(imag(x));
+    return std::isinf(std::real(x)) || std::isinf(std::imag(x));


Honestly I am not sure I understand how the hole thing works on device but if you look further down, real and imag function are implemented by call std::real and std::imag.
So for now it's not worse than it was and it allows to complete the scope I defined for this PR.
Of course these functions could easily cause problem down the line and opening an issue to work on it is appropriate.

dalg24 · 2025-09-30T12:08:35Z

Any chance to deprecate the header as well and redirect to a new header with appropriate prefix?

Would you be willing to move the traits definition to a new <KokkosKernels_ArithTraits.hpp>header and have < Kokkos_ArithTraits.hpp > just include it along with a using directive in the Kokkos:: namespace.

This avoid having us use the naming convention of Kokkos Core for something that lives in Kokkos Kernels. Next, I will modify header inclusions in the library to reflect this change. Signed-off-by: Luc Berger-Vergiat <lberge@sandia.gov>

Signed-off-by: Luc Berger-Vergiat <lberge@sandia.gov>

ndellingwood · 2025-10-01T02:04:42Z

We'll need to fix Trilinos for these changes, e.g.

In file included from /root/Trilinos/packages/stokhos/src/sacado/kokkos/vector/tpetra/Stokhos_Tpetra_MP_Vector.hpp:29:
/root/Trilinos/packages/stokhos/src/sacado/kokkos/vector/linalg/Kokkos_ArithTraits_MP_Vector.hpp:24:7: error: cannot specialize a dependent template
   24 | class ArithTraits< Sacado::MP::Vector<S> > {

ndellingwood · 2025-10-01T02:05:47Z

@lucbv just to check, these changes only apply to versions >= 5.0 ? (So I know how to guard in Trilinos)

dalg24 · 2025-10-01T02:24:09Z

I suppose you could do

#if __has_include(KokkosKernels_ArithTraits.hpp)  // since 5.0

Compatibility update corresponding to kokkos/kokkos-kernels#2771 Signed-off-by: Nathan Ellingwood <ndellin@sandia.gov>

…40799 Compatibility update corresponding to kokkos/kokkos-kernels#2771 Signed-off-by: Nathan Ellingwood <ndellin@sandia.gov>

Compatibility update corresponding to kokkos/kokkos-kernels#2771 Signed-off-by: Nathan Ellingwood <ndellin@sandia.gov>

lucbv · 2025-10-01T14:55:32Z

Yes this would only apply to versions of Kokkos >= 5.0 so for a 4.7.2 release we would not want this change.

Compatibility update corresponding to kokkos/kokkos-kernels#2771 Signed-off-by: Nathan Ellingwood <ndellin@sandia.gov>

…40799 Compatibility update corresponding to kokkos/kokkos-kernels#2771 Signed-off-by: Nathan Ellingwood <ndellin@sandia.gov>

Compatibility update corresponding to kokkos/kokkos-kernels#2771 Signed-off-by: Nathan Ellingwood <ndellin@sandia.gov>

lucbv requested review from dalg24 and ndellingwood September 15, 2025 14:57

lucbv self-assigned this Sep 15, 2025

lucbv added the Cleanup Code maintenance that isn't a bugfix or new feature label Sep 15, 2025

dalg24 reviewed Sep 15, 2025

View reviewed changes

lucbv added 2 commits September 29, 2025 13:18

Common - ArithTraits: moving from Kokkos to KokkosKernels

f486683

This simply moves the class to a new namespace to avoid having it in the Kokkos namespace. Signed-off-by: Luc Berger-Vergiat <lberge@sandia.gov>

Applying change of namespace to library and tests

bdef930

Signed-off-by: Luc Berger-Vergiat <lberge@sandia.gov>

lucbv force-pushed the move_arith_traits branch from d1ff0ad to bdef930 Compare September 29, 2025 20:52

lucbv added 2 commits September 29, 2025 15:29

Trying to fix the issue with sycl...

d90eff8

Signed-off-by: Luc Berger-Vergiat <lberge@sandia.gov>

More fixes for std::complex<T>

f0c21ca

Signed-off-by: Luc Berger-Vergiat <lberge@sandia.gov>

dalg24 reviewed Sep 30, 2025

View reviewed changes

lucbv added 3 commits September 30, 2025 09:38

Updating header inclusion to use new KokkosKernels_ArithTraits.hpp

782b229

Signed-off-by: Luc Berger-Vergiat <lberge@sandia.gov>

Applying clang-format

560e9d4

Signed-off-by: Luc Berger-Vergiat <lberge@sandia.gov>

dalg24 approved these changes Sep 30, 2025

View reviewed changes

lucbv merged commit 14f8cbe into kokkos:develop Sep 30, 2025
24 of 25 checks passed

lucbv deleted the move_arith_traits branch September 30, 2025 22:23

dalg24 mentioned this pull request Sep 30, 2025

Kokkos compatibility: Move InnerProductSpaceTraits to KokkosKernels #2799

Open

2 tasks

ndellingwood added a commit to ndellingwood/Trilinos that referenced this pull request Oct 1, 2025

stokhos: update ArithTraits namespace for KOKKOS_VERSION > 40799

0de0684

Compatibility update corresponding to kokkos/kokkos-kernels#2771 Signed-off-by: Nathan Ellingwood <ndellin@sandia.gov>

ndellingwood added a commit to ndellingwood/Trilinos that referenced this pull request Oct 1, 2025

adelus: update ArithTraits namespace for KOKKOS_VERSION > 40799

a773a6d

Compatibility update corresponding to kokkos/kokkos-kernels#2771 Signed-off-by: Nathan Ellingwood <ndellin@sandia.gov>

ndellingwood added a commit to ndellingwood/Trilinos that referenced this pull request Oct 1, 2025

belos: update ArithTraits namespace for KOKKOS_VERSION > 40799

3755fe0

Compatibility update corresponding to kokkos/kokkos-kernels#2771 Signed-off-by: Nathan Ellingwood <ndellin@sandia.gov>

ndellingwood added a commit to ndellingwood/Trilinos that referenced this pull request Oct 1, 2025

ifpack2: update ArithTraits namespace for KOKKOS_VERSION > 40799

4467ed5

Compatibility update corresponding to kokkos/kokkos-kernels#2771 Signed-off-by: Nathan Ellingwood <ndellin@sandia.gov>

ndellingwood added a commit to ndellingwood/Trilinos that referenced this pull request Oct 1, 2025

amesos2: update ArithTraits namespace for KOKKOS_VERSION > 40799

ffb40f0

Compatibility update corresponding to kokkos/kokkos-kernels#2771 Signed-off-by: Nathan Ellingwood <ndellin@sandia.gov>

ndellingwood added a commit to ndellingwood/Trilinos that referenced this pull request Oct 1, 2025

galeri: update ArithTraits namespace for KOKKOS_VERSION > 40799

fd71f74

Compatibility update corresponding to kokkos/kokkos-kernels#2771 Signed-off-by: Nathan Ellingwood <ndellin@sandia.gov>

ndellingwood added a commit to ndellingwood/Trilinos that referenced this pull request Oct 1, 2025

minitensor: update ArithTraits namespace for KOKKOS_VERSION > 40799

cfbb1b6

Compatibility update corresponding to kokkos/kokkos-kernels#2771 Signed-off-by: Nathan Ellingwood <ndellin@sandia.gov>

ndellingwood added a commit to ndellingwood/Trilinos that referenced this pull request Oct 1, 2025

muelu: update ArithTraits namespace for KOKKOS_VERSION > 40799

a0ec3cc

Compatibility update corresponding to kokkos/kokkos-kernels#2771 Signed-off-by: Nathan Ellingwood <ndellin@sandia.gov>

ndellingwood added a commit to ndellingwood/Trilinos that referenced this pull request Oct 1, 2025

belos: update ArithTraits namespace for KOKKOS_VERSION > 40799

f9a986f

Compatibility update corresponding to kokkos/kokkos-kernels#2771 Signed-off-by: Nathan Ellingwood <ndellin@sandia.gov>

ndellingwood added a commit to ndellingwood/Trilinos that referenced this pull request Oct 1, 2025

ifpack2: update ArithTraits namespace for KOKKOS_VERSION > 40799

3c84a52

Compatibility update corresponding to kokkos/kokkos-kernels#2771 Signed-off-by: Nathan Ellingwood <ndellin@sandia.gov>

ndellingwood added a commit to ndellingwood/Trilinos that referenced this pull request Oct 1, 2025

amesos2: update ArithTraits namespace for KOKKOS_VERSION > 40799

741098c

Compatibility update corresponding to kokkos/kokkos-kernels#2771 Signed-off-by: Nathan Ellingwood <ndellin@sandia.gov>

ndellingwood added a commit to ndellingwood/Trilinos that referenced this pull request Oct 1, 2025

galeri: update ArithTraits namespace for KOKKOS_VERSION > 40799

17eff20

Compatibility update corresponding to kokkos/kokkos-kernels#2771 Signed-off-by: Nathan Ellingwood <ndellin@sandia.gov>

ndellingwood added a commit to ndellingwood/Trilinos that referenced this pull request Oct 1, 2025

minitensor: update ArithTraits namespace for KOKKOS_VERSION > 40799

50384a1

Compatibility update corresponding to kokkos/kokkos-kernels#2771 Signed-off-by: Nathan Ellingwood <ndellin@sandia.gov>

ndellingwood added a commit to ndellingwood/Trilinos that referenced this pull request Oct 1, 2025

muelu: update ArithTraits namespace for KOKKOS_VERSION > 40799

c132545

Compatibility update corresponding to kokkos/kokkos-kernels#2771 Signed-off-by: Nathan Ellingwood <ndellin@sandia.gov>

ndellingwood added a commit to ndellingwood/Trilinos that referenced this pull request Oct 1, 2025

nox: update ArithTraits namespace for KOKKOS_VERSION > 40799

12b6011

Compatibility update corresponding to kokkos/kokkos-kernels#2771 Signed-off-by: Nathan Ellingwood <ndellin@sandia.gov>

ndellingwood added a commit to ndellingwood/Trilinos that referenced this pull request Oct 1, 2025

panzer: update ArithTraits namespace for KOKKOS_VERSION > 40799

b01cdd6

Compatibility update corresponding to kokkos/kokkos-kernels#2771 Signed-off-by: Nathan Ellingwood <ndellin@sandia.gov>

ndellingwood added a commit to ndellingwood/Trilinos that referenced this pull request Oct 1, 2025

shylu: update ArithTraits namespace for KOKKOS_VERSION > 40799

e32af06

Compatibility update corresponding to kokkos/kokkos-kernels#2771 Signed-off-by: Nathan Ellingwood <ndellin@sandia.gov>

ndellingwood added a commit to ndellingwood/Trilinos that referenced this pull request Oct 1, 2025

tpetra: update ArithTraits namespace for KOKKOS_VERSION > 40799

5a299c1

Compatibility update corresponding to kokkos/kokkos-kernels#2771 Signed-off-by: Nathan Ellingwood <ndellin@sandia.gov>

ndellingwood added a commit to ndellingwood/Trilinos that referenced this pull request Oct 1, 2025

zoltan2: update ArithTraits namespace for KOKKOS_VERSION > 40799

1869d11

Compatibility update corresponding to kokkos/kokkos-kernels#2771 Signed-off-by: Nathan Ellingwood <ndellin@sandia.gov>

ndellingwood added a commit to ndellingwood/Trilinos that referenced this pull request Oct 1, 2025

xpetra: update ArithTraits namespace for KOKKOS_VERSION > 40799

e337623

Compatibility update corresponding to kokkos/kokkos-kernels#2771 Signed-off-by: Nathan Ellingwood <ndellin@sandia.gov>

dalg24 mentioned this pull request Oct 1, 2025

Update headers in preparation for the 5.0 release #2795

Merged

eeprude pushed a commit to eeprude/Trilinos that referenced this pull request Oct 9, 2025

stokhos: update ArithTraits namespace for KOKKOS_VERSION > 40799

359aec8

Compatibility update corresponding to kokkos/kokkos-kernels#2771 Signed-off-by: Nathan Ellingwood <ndellin@sandia.gov>

eeprude pushed a commit to eeprude/Trilinos that referenced this pull request Oct 9, 2025

adelus: update ArithTraits namespace for KOKKOS_VERSION > 40799

0b703d3

Compatibility update corresponding to kokkos/kokkos-kernels#2771 Signed-off-by: Nathan Ellingwood <ndellin@sandia.gov>

eeprude pushed a commit to eeprude/Trilinos that referenced this pull request Oct 9, 2025

belos: update ArithTraits namespace for KOKKOS_VERSION > 40799

a9ec0e9

Compatibility update corresponding to kokkos/kokkos-kernels#2771 Signed-off-by: Nathan Ellingwood <ndellin@sandia.gov>

eeprude pushed a commit to eeprude/Trilinos that referenced this pull request Oct 9, 2025

ifpack2: update ArithTraits namespace for KOKKOS_VERSION > 40799

5f05d31

Compatibility update corresponding to kokkos/kokkos-kernels#2771 Signed-off-by: Nathan Ellingwood <ndellin@sandia.gov>

eeprude pushed a commit to eeprude/Trilinos that referenced this pull request Oct 9, 2025

amesos2: update ArithTraits namespace for KOKKOS_VERSION > 40799

17bcc81

Compatibility update corresponding to kokkos/kokkos-kernels#2771 Signed-off-by: Nathan Ellingwood <ndellin@sandia.gov>

eeprude pushed a commit to eeprude/Trilinos that referenced this pull request Oct 9, 2025

galeri: update ArithTraits namespace for KOKKOS_VERSION > 40799

1e1f98d

Compatibility update corresponding to kokkos/kokkos-kernels#2771 Signed-off-by: Nathan Ellingwood <ndellin@sandia.gov>

eeprude pushed a commit to eeprude/Trilinos that referenced this pull request Oct 9, 2025

minitensor: update ArithTraits namespace for KOKKOS_VERSION > 40799

479d8a8

Compatibility update corresponding to kokkos/kokkos-kernels#2771 Signed-off-by: Nathan Ellingwood <ndellin@sandia.gov>

eeprude pushed a commit to eeprude/Trilinos that referenced this pull request Oct 9, 2025

muelu: update ArithTraits namespace for KOKKOS_VERSION > 40799

4c00203

Compatibility update corresponding to kokkos/kokkos-kernels#2771 Signed-off-by: Nathan Ellingwood <ndellin@sandia.gov>

eeprude pushed a commit to eeprude/Trilinos that referenced this pull request Oct 9, 2025

nox: update ArithTraits namespace for KOKKOS_VERSION > 40799

acbb1dc

Compatibility update corresponding to kokkos/kokkos-kernels#2771 Signed-off-by: Nathan Ellingwood <ndellin@sandia.gov>

eeprude pushed a commit to eeprude/Trilinos that referenced this pull request Oct 9, 2025

panzer: update ArithTraits namespace for KOKKOS_VERSION > 40799

a298989

Compatibility update corresponding to kokkos/kokkos-kernels#2771 Signed-off-by: Nathan Ellingwood <ndellin@sandia.gov>

eeprude pushed a commit to eeprude/Trilinos that referenced this pull request Oct 9, 2025

shylu: update ArithTraits namespace for KOKKOS_VERSION > 40799

160a8b6

Compatibility update corresponding to kokkos/kokkos-kernels#2771 Signed-off-by: Nathan Ellingwood <ndellin@sandia.gov>

eeprude pushed a commit to eeprude/Trilinos that referenced this pull request Oct 9, 2025

tpetra: update ArithTraits namespace for KOKKOS_VERSION > 40799

a479c04

Compatibility update corresponding to kokkos/kokkos-kernels#2771 Signed-off-by: Nathan Ellingwood <ndellin@sandia.gov>

eeprude pushed a commit to eeprude/Trilinos that referenced this pull request Oct 9, 2025

zoltan2: update ArithTraits namespace for KOKKOS_VERSION > 40799

b61e80e

Compatibility update corresponding to kokkos/kokkos-kernels#2771 Signed-off-by: Nathan Ellingwood <ndellin@sandia.gov>

eeprude pushed a commit to eeprude/Trilinos that referenced this pull request Oct 9, 2025

xpetra: update ArithTraits namespace for KOKKOS_VERSION > 40799

dea2df1

Compatibility update corresponding to kokkos/kokkos-kernels#2771 Signed-off-by: Nathan Ellingwood <ndellin@sandia.gov>

Common - ArithTraits: moving from Kokkos to KokkosKernels #2771

Common - ArithTraits: moving from Kokkos to KokkosKernels #2771

Uh oh!

Conversation

lucbv commented Sep 15, 2025

Uh oh!

dalg24 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dalg24 commented Sep 30, 2025

Uh oh!

Uh oh!

ndellingwood commented Oct 1, 2025

Uh oh!

ndellingwood commented Oct 1, 2025

Uh oh!

dalg24 commented Oct 1, 2025

Uh oh!

lucbv commented Oct 1, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants