Skip to content

Update the bisect break condition in RCB #2766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 12, 2025
Merged

Update the bisect break condition in RCB #2766

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0cda218
Update break condition in bisect
vqd8a Sep 11, 2025
164cf15
Remove unused file
vqd8a Sep 11, 2025
a435a2b
Merge branch 'develop' into rcb-change-break-condition-bisect
vqd8a Sep 11, 2025
cf9f784
Use FOR loop as suggested
vqd8a Sep 12, 2025
246e7f1
Merge branch 'rcb-change-break-condition-bisect' of https://github.co…
vqd8a Sep 12, 2025
956e8d1
Merge branch 'develop' into rcb-change-break-condition-bisect
vqd8a Sep 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions graph/impl/KokkosGraph_RCB_impl.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,9 +132,12 @@ inline void bisect(const coors_view_type &coors_1d, const value_type &init_min_v
value_type min_val = init_min_val;
value_type max_val = init_max_val;
value_type p1_weight, p2_weight;
value_type prev_weight_ratio = 0;
value_type curr_weight_ratio;
while (1) {
value_type weight_ratio;
const int max_bisection_steps = 11;
// For now, limit the number of times finding mid point to ten to make RCB work with Sierra T/F coordinates
// TODO: - allow users to pass max_bisection_steps as an input parameter
// - or switch to use the median, which is probably a better solution
for (int bisection_step = 0; bisection_step < max_bisection_steps; ++bisection_step) {
value_type mid_point = (max_val + min_val) / 2.0;
p1_size = 0;
p2_size = 0;
Expand All @@ -151,11 +154,9 @@ inline void bisect(const coors_view_type &coors_1d, const value_type &init_min_v
p1_weight = static_cast<value_type>(p1_size);
p2_weight = static_cast<value_type>(p2_size);

curr_weight_ratio = std::max(p1_weight, p2_weight) / std::min(p1_weight, p2_weight);
weight_ratio = std::max(p1_weight, p2_weight) / std::min(p1_weight, p2_weight);

if (curr_weight_ratio < 1.1)
break;
else if (curr_weight_ratio == prev_weight_ratio)
if (weight_ratio < 1.1)
break;
else {
// Update min_val or max_val to calculate a new mid_point
Expand All @@ -164,7 +165,6 @@ inline void bisect(const coors_view_type &coors_1d, const value_type &init_min_v
min_val = mid_point;
else
max_val = mid_point;
prev_weight_ratio = curr_weight_ratio;
}
}
}
Expand Down
Loading