Update the bisect break condition in RCB #2766
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vinh Dang <vqdang@sandia.gov>
Signed-off-by: Vinh Dang <vqdang@sandia.gov>
lucbv
approved these changes
Sep 11, 2025
|
We don't require the h100 test as of #2755, I'm not sure why it's showing up in the list of checks. |
Signed-off-by: Vinh Dang <vqdang@sandia.gov>
…m/vqd8a/kokkos-kernels into rcb-change-break-condition-bisect
lucbv
approved these changes
Sep 12, 2025
I probably need to remove it from the set of required action, which also makes me feel I should update the required actions to include the new Lychee and Kumquat builds. |
Yes. It would be great to have this in 4.7.01. Is it too late now? |
|
@cwpearson after updating the branch protection settings the old github action does not appear anymore : ) |
|
@ndellingwood Can this PR included in 4.7.01? Thanks. |
ndellingwood
pushed a commit
to ndellingwood/kokkos-kernels
that referenced
this pull request
Sep 12, 2025
* Update break condition in bisect Signed-off-by: Vinh Dang <vqdang@sandia.gov> * Remove unused file Signed-off-by: Vinh Dang <vqdang@sandia.gov> * Use FOR loop as suggested Signed-off-by: Vinh Dang <vqdang@sandia.gov> --------- Signed-off-by: Vinh Dang <vqdang@sandia.gov>
ndellingwood
added a commit
that referenced
this pull request
Sep 13, 2025
* Update the bisect break condition in RCB (#2766) * Update break condition in bisect Signed-off-by: Vinh Dang <vqdang@sandia.gov> * Remove unused file Signed-off-by: Vinh Dang <vqdang@sandia.gov> * Use FOR loop as suggested Signed-off-by: Vinh Dang <vqdang@sandia.gov> --------- Signed-off-by: Vinh Dang <vqdang@sandia.gov> * update changelog - pr 2766 Signed-off-by: Nathan Ellingwood <ndellin@sandia.gov> --------- Signed-off-by: Vinh Dang <vqdang@sandia.gov> Signed-off-by: Nathan Ellingwood <ndellin@sandia.gov> Co-authored-by: Vinh Dang <vqdang@sandia.gov>
prateekchawla168
pushed a commit
to FZJ-JSC/kokkos-kernels
that referenced
this pull request
Sep 18, 2025
* Update break condition in bisect Signed-off-by: Vinh Dang <vqdang@sandia.gov> * Remove unused file Signed-off-by: Vinh Dang <vqdang@sandia.gov> * Use FOR loop as suggested Signed-off-by: Vinh Dang <vqdang@sandia.gov> --------- Signed-off-by: Vinh Dang <vqdang@sandia.gov>
lucbv
added a commit
that referenced
this pull request
Sep 23, 2025
* Update to 4.7.01 Signed-off-by: Nathan Ellingwood <ndellin@sandia.gov> * Add setNumRows, setNumCols to sparse matrix structures (#2700) * Added setNumRows/setNumCols to sparse matrix classes * Update docs for crs/bsr with setNumCols * Add documentation for ccs, coo matrices. * Update header-docpage mapping Signed-off-by: Brian Kelley <bmkelle@sandia.gov> * Batched - SVD: adding new special matrix test for issue #2650 (#2706) The issue reports that Batched SVD hangs on a 3x6 matrix. Adding it to our list of special matrices to test for will avoid potential future regressions. Limiting the maximum number of iterations by introducing a for loop instead of a while loop and an input parameter to pass a maximum number of iterations. Signed-off-by: Luc Berger-Vergiat <lberge@sandia.gov> * Use value_type of YVector for alpha and beta (#2730) Signed-off-by: Vinh Dang <vqdang@sandia.gov> * cusparse spmv_mv: use native if y not 16B aligned (#2746) This is the same workaround as #1889, but now for the spmv mv (rank-2) case. Also add a new spmv test that replicates this kind of issue for both rank-1 and rank-2 cases. Signed-off-by: Brian Kelley <bmkelle@sandia.gov> * KokkosKernels_ENABLE_BENCHMARK -> KokkosKernels_ENABLE_BENCHMARKS (#2729) * KokkosKernels_ENABLE_BENCHMARK -> KokkosKernels_ENABLE_BENCHMARKS Signed-off-by: Carl Pearson <cwpears@sandia.gov> * remove copy-pasted code from benchmarks/sparse/CMakeLists.txt Signed-off-by: Carl Pearson <cwpears@sandia.gov> --------- Signed-off-by: Carl Pearson <cwpears@sandia.gov> * First implementation of recursive coordinate bisection (RCB) in graph (#2708) * Add RCB to Graph component Signed-off-by: Vinh Dang <vqdang@sandia.gov> * Add unit test for RCB Signed-off-by: Vinh Dang <vqdang@sandia.gov> * Utility function to extract diagonal blocks in CRS format after RCB reordering Signed-off-by: Vinh Dang <vqdang@sandia.gov> * Apply clang format Signed-off-by: Vinh Dang <vqdang@sandia.gov> * Fix clang format Signed-off-by: Vinh Dang <vqdang@sandia.gov> * Use explicit braces Signed-off-by: Vinh Dang <vqdang@sandia.gov> * Looping along coordinate dimensions Signed-off-by: Vinh Dang <vqdang@sandia.gov> * Use create_mirror instead of create_mirror_view Signed-off-by: Vinh Dang <vqdang@sandia.gov> * Update the src_doc_mapping dictionary with empty values Signed-off-by: Vinh Dang <vqdang@sandia.gov> * Update the src_doc_mapping dictionary Signed-off-by: Vinh Dang <vqdang@sandia.gov> * Changes addressing comments Signed-off-by: Vinh Dang <vqdang@sandia.gov> * Add input checks and move the algorithm implementation to impl Signed-off-by: Vinh Dang <vqdang@sandia.gov> * Add documents Signed-off-by: Vinh Dang <vqdang@sandia.gov> * Update docs Signed-off-by: Vinh Dang <vqdang@sandia.gov> * Update graph-index.rst Signed-off-by: Vinh Dang <vqdang@sandia.gov> * Update sparse-index.rst Signed-off-by: Vinh Dang <vqdang@sandia.gov> --------- Signed-off-by: Vinh Dang <vqdang@sandia.gov> * Add optional argument to configure sorting algorithm used in KokkosSparse:sort_crs_matrix (#2714) * Add optional SortType option Signed-off-by: malphil <malphil@sandia.gov> * Apply clang-format Signed-off-by: malphil <malphil@sandia.gov> * Suppress complaint around undocumented file Signed-off-by: malphil <malphil@sandia.gov> * Add in SandiaAI generated documentation file to please auto-tester Signed-off-by: malphil <malphil@sandia.gov> * Resolve issues related to documentation Signed-off-by: malphil <malphil@sandia.gov> * Address reviewer comments Signed-off-by: malphil <malphil@sandia.gov> * Fix title underline issue in docs Signed-off-by: malphil <malphil@sandia.gov> * Fix missing SortType -> SortAlgorithm Signed-off-by: malphil <malphil@sandia.gov> --------- Signed-off-by: malphil <malphil@sandia.gov> Co-authored-by: malphil <malphil@sandia.gov> * Clean up old workaround, update RCB for host_mirror_type renaming (#2721) * Small update to RCB to avoid deprecated code (HostMirror -> host_mirror_type) * Clean up bulk sort disabled path This was a workaround for a Kokkos issue that has been fixed since 4.4, so the workaround is no longer needed. Signed-off-by: Brian Kelley <bmkelle@sandia.gov> * Drop deprecated double4 type for CUDA 13 (#2718) Signed-off-by: Nuno Nobre <nuno.nobre@stfc.ac.uk> Co-authored-by: Luc Berger <lberge@sandia.gov> * Update changelog for 4.7.01 (#2764) Signed-off-by: Nathan Ellingwood <ndellin@sandia.gov> * [4.7.1] Update the bisect break condition in RCB (#2766) (#2768) * Update the bisect break condition in RCB (#2766) * Update break condition in bisect Signed-off-by: Vinh Dang <vqdang@sandia.gov> * Remove unused file Signed-off-by: Vinh Dang <vqdang@sandia.gov> * Use FOR loop as suggested Signed-off-by: Vinh Dang <vqdang@sandia.gov> --------- Signed-off-by: Vinh Dang <vqdang@sandia.gov> * update changelog - pr 2766 Signed-off-by: Nathan Ellingwood <ndellin@sandia.gov> --------- Signed-off-by: Vinh Dang <vqdang@sandia.gov> Signed-off-by: Nathan Ellingwood <ndellin@sandia.gov> Co-authored-by: Vinh Dang <vqdang@sandia.gov> * update master_history.txt Signed-off-by: Nathan Ellingwood <ndellin@sandia.gov> --------- Signed-off-by: Nathan Ellingwood <ndellin@sandia.gov> Signed-off-by: Brian Kelley <bmkelle@sandia.gov> Signed-off-by: Luc Berger-Vergiat <lberge@sandia.gov> Signed-off-by: Vinh Dang <vqdang@sandia.gov> Signed-off-by: Carl Pearson <cwpears@sandia.gov> Signed-off-by: malphil <malphil@sandia.gov> Signed-off-by: Nuno Nobre <nuno.nobre@stfc.ac.uk> Co-authored-by: brian-kelley <bmkelle@sandia.gov> Co-authored-by: Luc Berger <lberge@sandia.gov> Co-authored-by: Vinh Dang <vqdang@sandia.gov> Co-authored-by: Carl Pearson <cwpearson@users.noreply.github.com> Co-authored-by: Malachi <malachi2@illinois.edu> Co-authored-by: malphil <malphil@sandia.gov> Co-authored-by: Nuno Nobre <nuno.nobre@stfc.ac.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to make a minor change for the bisect break condition in RCB to make RCB work with Sierra T/F coordinates.