- 
                Notifications
    You must be signed in to change notification settings 
- Fork 9
Allow is_transpose_needed to work on std::size_t based array #350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow is_transpose_needed to work on std::size_t based array #350
Conversation
425825c    to
    9cc4277      
    Compare
  
    | Looks fine to me. Just one observation. There is no test for  | 
| @science-enthusiast 
 Strictly speaking, we can parameterize over more types:  | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine otherwise
        
          
                common/src/KokkosFFT_utils.hpp
              
                Outdated
          
        
      | /// \tparam DIM The dimensionality of the axes | ||
| /// | ||
| /// \param[in] map The map used for permutation | ||
| template <typename IntType, std::size_t DIM> | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IntType should be renamed to IndexType.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
I have fixed accordingly
| Thanks @science-enthusiast @PaulGannay I will merge this | 
This PR aims at generalizing
is_transpose_neededhelper.It may be that the input type is
std::array<std::size_t, DIM>for distributed case