Introduce safe transpose #339
Merged
+303
−100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yasahi-hpc
force-pushed
the
introduce-safe-transpose
branch
from
812d437 to
8ed52f0
Compare
PaulGannay
approved these changes
Oct 31, 2025
Comment on lines
+148
to
+151
| /// \tparam iType The index type used for the view | ||
| /// \tparam ArgBoundsCheck The bounds check type (default is Off) | ||
| template <typename ExecutionSpace, typename InViewType, typename OutViewType, | ||
| typename iType> | ||
| typename iType, typename ArgBoundsCheck = BoundsCheck::Off> |
There was a problem hiding this comment.
It's a bit unrelated with this PR but I would take advantage of it to change iType to IndexType for consistency.
There was a problem hiding this comment.
Thanks for the review
It's a bit unrelated with this PR but I would take advantage of it to change iType to IndexType for consistency.
I guess I use iType in multiple functions
Can I rename them in another PR?
There was a problem hiding this comment.
Sure, I was proposing to do this one now since you are touching it, but if you want to change them all it would be better to do it in a dedicated PR.
There was a problem hiding this comment.
Sure, I will merge this first and make a dedicated PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims at introducing bound check option to transpose function.
BoundsCheckoption to Transpose functor.transposefunction to performdeep_copyif transpose is not needed (Done in Copy if map is identical in transpose helper #345)transposefunction to work on Views with different Layout (Done in Make transpose helper to work on Views with different layout #344)transposefunction to work on integral typeis_transpose_neededfunction to work on integral type (Done in Allow is_transpose_needed to work on std::size_t based array #350)bounds_check. Needs to improve the case withbounds_checkto work on differentViewshapes