Skip to content

Remove provider settings check/generation #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 27, 2025

Conversation

brichet
Copy link
Collaborator

@brichet brichet commented Jun 27, 2025

This PR remove the automatic use of provider settings checker/generation.

Currently the script that perform this check/generation is still there.
We should probably remove it as well if we don't expect to fix it (see below for current failures).

The failing tests seem to be related to the upgrade of zod dependency, after this (huge) PR colinhacks/zod#4074, that has been included in 3.25.X.
It adds the use of ThisType which is not understood by ts-json-schema-generator.

I don't know how to fix it, but we have the same issue in #110

Originally posted by @brichet in #100 (comment)

Related issues

Fixes #104
Related to #107 and #64
Related to test failures in #100 and #110.

@brichet brichet added bug Something isn't working maintenance labels Jun 27, 2025
@brichet brichet requested a review from jtpio June 27, 2025 14:44
Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks!

@jtpio jtpio merged commit 258d16d into jupyterlite:main Jun 27, 2025
10 of 11 checks passed
@brichet brichet deleted the remove_settings_generation branch June 27, 2025 15:18
@jtpio jtpio mentioned this pull request Jun 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop settings checker in tests
2 participants