Skip to content

Commit 258d16d

Browse files
authored
Remove provider settings check/generation (#113)
* Remove the settings check test and settings generation in build:prod script * Add linter on settings schema
1 parent e2b6477 commit 258d16d

File tree

7 files changed

+33
-156
lines changed

7 files changed

+33
-156
lines changed

.github/workflows/build.yml

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -89,19 +89,3 @@ jobs:
8989
- uses: actions/checkout@v4
9090
- uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1
9191
- uses: jupyterlab/maintainer-tools/.github/actions/check-links@v1
92-
93-
check_settings:
94-
name: Check default provider settings
95-
runs-on: ubuntu-latest
96-
timeout-minutes: 5
97-
steps:
98-
- name: Checkout
99-
uses: actions/checkout@v4
100-
- name: Base Setup
101-
uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1
102-
- name: Install jupyterlab
103-
run: python -m pip install -U "jupyterlab>=4.0.0,<5"
104-
- name: Install node packages
105-
run: jlpm install
106-
- name: Check the settings
107-
run: jlpm settings:check

.gitignore

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,10 +11,6 @@ jupyterlite_ai/labextension
1111
# Version file is handled by hatchling
1212
jupyterlite_ai/_version.py
1313

14-
# Schema and module built at build time
15-
src/settings/schemas/index.ts
16-
src/settings/schemas/_generated
17-
1814
# Created by https://www.gitignore.io/api/python
1915
# Edit at https://www.gitignore.io/?templates=python
2016

.prettierignore

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,4 +5,3 @@ node_modules
55
!/package.json
66
jupyterlite_ai
77
.venv
8-
src/default-providers/*/settings-schema.json

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929
"scripts": {
3030
"build": "jlpm build:lib && jlpm build:labextension:dev",
3131
"build:dev": "jlpm build:lib && jlpm build:labextension:dev",
32-
"build:prod": "jlpm settings:build && jlpm clean && jlpm build:lib:prod && jlpm build:labextension",
32+
"build:prod": "jlpm clean && jlpm build:lib:prod && jlpm build:labextension",
3333
"build:labextension": "jupyter labextension build .",
3434
"build:labextension:dev": "jupyter labextension build --development True .",
3535
"build:lib": "tsc --sourceMap",

src/default-providers/Ollama/settings-schema.json

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -90,10 +90,7 @@
9090
"type": "boolean"
9191
},
9292
"keepAlive": {
93-
"type": [
94-
"string",
95-
"number"
96-
],
93+
"type": ["string", "number"],
9794
"default": "5m"
9895
},
9996
"stop": {

0 commit comments

Comments
 (0)