Skip to content

CI: advance the Python version support window #2246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
+5 −3
Closed

CI: advance the Python version support window #2246

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7a29213
CI: advance the Python version support window
jayaddison Sep 29, 2025
30519e4
CI: add Python3.13 to GitHub Actions `cron` workflows
jayaddison Sep 29, 2025
eb306c1
Packaging: add Python3.13 to PyPi classifiers
jayaddison Sep 29, 2025
e9feb94
Packaging: remove Python3.8 (near EOL) from PyPi classifiers
jayaddison Sep 29, 2025
ef8b749
Changelog: add changeset description (adds py3.13, removes py3.8)
jayaddison Sep 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ jobs:
fromJSON(
inputs.cpython-versions
&& inputs.cpython-versions
|| '["3.8", "3.9", "3.10", "3.11", "3.12"]'
|| '["3.9", "3.10", "3.11", "3.12", "3.13"]'
)
}}
pip-version: >-
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/cron.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,6 @@ jobs:
uses: ./.github/workflows/ci.yml
with:
cpython-versions: >-
["3.10", "3.11", "3.12"]
["3.10", "3.11", "3.12", "3.13"]
cpython-pip-version: >-
["main", "latest", "supported", "lowest"]
2 changes: 2 additions & 0 deletions changelog.d/2246.misc.md
View file
Open in desktop
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This mustn't be in a section with random unimportant changes. There's a removal and addition of support. There's respective sections for both.

Although, I don't think we're in rush to drop 3.8 right away. Is it causing problems?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok; would it be preferable to isolate this into two changesets, one to add Python3.13 as a feature change note, and then potentially a Python3.8 deprecation?

I'm not aware of any problems due to Python3.8 here, nope - my main motivation was to maintain a similar level of CI resource usage/cost, despite exercising an extra Python version.

In fact: I also note that I omitted to update the requires-python directive in the pyproject.toml here; so in fact this changeset does not entirely remove Py3.8 support, as it stands.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would treat two PRs as preferable, yes.

Adding and removing versions touches different metadata, e.g., Requires-Python when the lower bound moves.

Upon reflection, I don't think we're ready to drop 3.8 quite yet. This is open to debate, but I'd like to do one more bugfix release before removing a version (even an EOL one; lots of orgs move versions slowly).

Once we don't support 3.8, a series of small cleanups come into play, e.g., the black and pyupgrade version numbers. I think I prefer to do those separately from the version bump as well, which I would confine to package metadata and CI configuration.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @sirosen - I'll close this and re-open a more narrowly-focused pull request that adds py3.13 without removing py3.8 support.

Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Test and declare Python 3.13 support in `pip-tools`; remove support for Python 3.8
-- by {user}`jayaddison` (for OpenCulinary).
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,11 @@ classifiers = [
"Operating System :: OS Independent",
"Programming Language :: Python :: 3 :: Only",
"Programming Language :: Python :: 3",
"Programming Language :: Python :: 3.8",
"Programming Language :: Python :: 3.9",
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.11",
"Programming Language :: Python :: 3.12",
"Programming Language :: Python :: 3.13",
"Programming Language :: Python :: Implementation :: CPython",
"Programming Language :: Python :: Implementation :: PyPy",
"Programming Language :: Python",
Expand Down
Loading