-
-
Notifications
You must be signed in to change notification settings - Fork 628
CI: advance the Python version support window #2246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
CI: advance the Python version support window #2246
Conversation
My availability to respond to review feedback and/or support this changeset next week will be limited; please keep that in mind if considering potential merge/release inclusion. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This mustn't be in a section with random unimportant changes. There's a removal and addition of support. There's respective sections for both.
Although, I don't think we're in rush to drop 3.8 right away. Is it causing problems?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok; would it be preferable to isolate this into two changesets, one to add Python3.13 as a feature
change note, and then potentially a Python3.8 deprecation
?
I'm not aware of any problems due to Python3.8 here, nope - my main motivation was to maintain a similar level of CI resource usage/cost, despite exercising an extra Python version.
In fact: I also note that I omitted to update the requires-python
directive in the pyproject.toml
here; so in fact this changeset does not entirely remove Py3.8 support, as it stands.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would treat two PRs as preferable, yes.
Adding and removing versions touches different metadata, e.g., Requires-Python
when the lower bound moves.
Upon reflection, I don't think we're ready to drop 3.8 quite yet. This is open to debate, but I'd like to do one more bugfix release before removing a version (even an EOL one; lots of orgs move versions slowly).
Once we don't support 3.8, a series of small cleanups come into play, e.g., the black
and pyupgrade
version numbers. I think I prefer to do those separately from the version bump as well, which I would confine to package metadata and CI configuration.
Contributor checklist
Included tests for the changes.changelog.d/
(seechangelog.d/README.md
for instructions) or the PR text says "no changelog needed".Maintainer checklist
skip-changelog
label.Resolves #2138.