-
Notifications
You must be signed in to change notification settings - Fork 11
Migrate to ROS2 #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to ROS2 #19
Conversation
…on-for-QpSolverCollection Feature/implement ros2 version for qp solver collection
Hi @chuoru @tuan311020022, |
@ThomasDuvinage
|
Thanks for your feedback. |
@ThomasDuvinage |
Thank you @chuoru . I reviewed it. I will merge it after the comments are incorporated and CI is passed. |
@mmurooka @ThomasDuvinage
Also, for osqp-eigen, there is some update in osqp which lead to osqp-eigen not able to be built, currently this repository's ci-cd using my version of osqp-eigen. I have made pull request to osqp-eigen wait for merging. Also also, I have modified QpSolverHpipm so no memory leak will happen when destructing the class (I found the memory leak using valgrind). |
Thanks @chuoru |
@mmurooka package generation for Ubuntu 22.04 and 24.04 cannot be done yet due to some unmet dependencies as mentioned above. |
Thank you @ThomasDuvinage I will review it today or tomorrow. |
If you wonder why the error concerning libeigen-qld is suddenly gone, I had to edit github-actions (commit) to export |
@chuoru I finished the migration of all other dependencies of BaselineWalkingController. It'll come up soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @ThomasDuvinage
I added some comments, so please merge after addressing them.
@ThomasDuvinage |
In order for packaging to pass on Ubuntu noble, nasoq package as to be published. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @ThomasDuvinage I added some comments. After addressing them, you can merge it without waiting for me to review it again.
@mmurooka Thanks for the feedback i'll merge |
Build quadratic solver with all solvers
Results:

Test using colcon ROS2