Skip to content

Implementation of RFC 0072 - Pluggable transfer types #1930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

mesemus
Copy link
Contributor

@mesemus mesemus commented Jan 19, 2025

Description

This PR implements changes from RFC 0072 - UI for multipart upload.

Note: needs inveniosoftware/invenio-records-resources#604 and #2008

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

Frontend

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

  1. You license your contribution under the same terms as the current repository’s license.
  2. You agree that you have the right to license your contribution under the current repository’s license.

@mesemus
Copy link
Contributor Author

mesemus commented Jan 19, 2025

mesemus added 3 commits May 16, 2025 08:50
* IfFileIsLocal is not used anymore as it was handling just one type of transport

* Switched to IfTransferType permission generators

* Note: needs inveniosoftware/invenio-records-resources#604
@mirekys mirekys force-pushed the contribution-multipart-transfer branch 2 times, most recently from ece76dd to 5f4feb2 Compare May 19, 2025 11:28
* addresses the UI part of RFC 0072: inveniosoftware/rfcs#91

* adds Uppy uploader field component
@mirekys mirekys force-pushed the contribution-multipart-transfer branch from 5f4feb2 to 0e95f60 Compare May 19, 2025 11:31
@tmorrell
Copy link
Contributor

I haven't gotten this to build properly on my standard invenio-cli based setup. I end up with

ERROR in ./js/invenio_rdm_records/src/deposit/fields/UppyUploader/index.js 10:0-55
Module not found: Error: Can't resolve './UppyUploader' in '/var/instance/assets/js/invenio_rdm_records/src/deposit/fields/UppyUploader'
Did you miss the leading dot in 'resolve.extensions'? Did you mean '[".*",".js",".jsx"]' instead of '["*",".js",".jsx"]'?

The rest of the UppyUploader files are there, just not the .jsx file. Is there any additional config I need to do to get the jsx file copied?

@mesemus mesemus marked this pull request as ready for review May 22, 2025 07:30
@mesemus mesemus marked this pull request as draft May 22, 2025 08:24
@mesemus
Copy link
Contributor Author

mesemus commented May 22, 2025

Closing this PR for the time being as it brings confusion - it contains both backend and fronted sources. We will open a new PR just for the fronted part as soon as the backend is merged.

To test the frontend in the meanwhile, please apply #2008 and then oarepo#1

@mesemus mesemus closed this May 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants