-
Notifications
You must be signed in to change notification settings - Fork 70
Documented API update from RFC 0072 #737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Connected pull requests: RFC 0072 |
... | ||
] | ||
``` | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add in that file size and checksum are optional parameters?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be included in v13. There is a bit on the permissions that should be checked before merging.
from invenio_administration.generators import Administration | ||
|
||
class MyRepositoryPermissionPolicy(RDMRecordPermissionPolicy): | ||
can_draft_create_files = RDMRecordPermissionPolicy.can_draft_transfer_files + [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure these permissions have been implemented. It works out of the box for me without modifying permissions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will have a look at it today.
* See inveniosoftware/rfcs#91 for details Co-authored-by: Mirek Simek <miroslav.simek@cesnet.cz>
ca49043
to
8fefe9e
Compare
Note that in upcoming "Reference" section refactor, File storage is going to be moved around/edited for clarity of audience and purpose. Currently it mixes REST API usage, with explanation of internals, with configuration for site administrators. You can separate those concerns out if you want, otherwise I will if that reorg lands after this PR. |
Description
This PR contains documentation of API changes proposed in RFC 0072.
Checklist
Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:
master
branch.production
branch following approval or indicate to a maintainer that it should be backported.Reminder
By using GitHub, you have already agreed to the GitHub’s Terms of Service including that: