Skip to content

Testing - tern bug fixes #829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 11, 2025
Merged

Testing - tern bug fixes #829

merged 2 commits into from
Mar 11, 2025

Conversation

edelarua
Copy link
Contributor

@edelarua edelarua commented Mar 7, 2025

@edelarua edelarua added the sme label Mar 7, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 7, 2025 •
edited
Loading

badge

Code Coverage Summary

Filename                     Stmts    Miss  Cover    Missing
-------------------------  -------  ------  -------  --------------------------------------------------------------------
R/ael01_nollt.R                  6       0  100.00%
R/ael02.R                       27       0  100.00%
R/ael03.R                       34       0  100.00%
R/aet01_aesi.R                 148       1  99.32%   214
R/aet01.R                      104       5  95.19%   77-80, 183
R/aet02.R                       44       0  100.00%
R/aet03.R                       76       0  100.00%
R/aet04.R                       88       0  100.00%
R/aet05_all.R                   11       0  100.00%
R/aet05.R                       44       1  97.73%   116
R/aet10.R                       42       0  100.00%
R/assertions.R                  93       7  92.47%   11-16, 123
R/cfbt01.R                     107       0  100.00%
R/checks.R                      14       0  100.00%
R/chevron_tlg-S4class.R         24       0  100.00%
R/chevron_tlg-S4methods.R      163       0  100.00%
R/cml02a_gl.R                    8       0  100.00%
R/cmt01a.R                      52       0  100.00%
R/coxt01.R                      49       1  97.96%   130
R/dmt01.R                       38       0  100.00%
R/dst01.R                       94       0  100.00%
R/dtht01.R                     102       6  94.12%   51, 55-59
R/egt02.R                       35       0  100.00%
R/egt03.R                       80       1  98.75%   157
R/egt05_qtcat.R                 78       0  100.00%
R/ext01.R                       59       1  98.31%   51
R/fstg01.R                      43       0  100.00%
R/fstg02.R                      48       0  100.00%
R/kmg01.R                       35       6  82.86%   35-40
R/lbt01.R                       59       0  100.00%
R/lbt04.R                       90       0  100.00%
R/lbt05.R                       66       2  96.97%   129-130
R/lbt06.R                       70       0  100.00%
R/lbt07.R                       93       0  100.00%
R/lbt14.R                       64       0  100.00%
R/lbt15.R                       20       0  100.00%
R/mht01.R                       55       0  100.00%
R/mng01.R                       97      12  87.63%   86, 90-94, 126-130, 133, 178
R/pdt01.R                       60       0  100.00%
R/pdt02.R                       68       0  100.00%
R/report_null.R                 29       0  100.00%
R/rmpt01.R                      59       1  98.31%   132
R/rmpt06.R                     134       3  97.76%   209-212
R/rspt01.R                      73       3  95.89%   156-159
R/rtables_utils.R              319      23  92.79%   51, 68, 119, 243, 264, 372-379, 446, 461-463, 465, 534-540, 550, 571
R/standard_rules.R              13       0  100.00%
R/ttet01.R                     121       3  97.52%   203-206
R/unwrap.R                      36       0  100.00%
R/utils.R                      178      13  92.70%   277-280, 284-287, 314, 318, 330, 332, 344
R/vst02.R                       45       1  97.78%   109
R/zzz.R                          1       1  0.00%    2
TOTAL                         3496      91  97.40%

Diff against main

Filename                     Stmts    Miss  Cover
-------------------------  -------  ------  --------
R/ael01_nollt.R                -15      -1  +4.76%
R/ael02.R                      +27       0  +100.00%
R/ael03.R                      +34       0  +100.00%
R/aet01_aesi.R                  -2       0  -0.01%
R/aet01.R                      +10      +4  -3.74%
R/aet02.R                       -6       0  +100.00%
R/aet03.R                       -1       0  +100.00%
R/aet04.R                       -1       0  +100.00%
R/aet05.R                       +4       0  +0.23%
R/aet10.R                       -1       0  +100.00%
R/assertions.R                  -6      +1  -1.47%
R/chevron_tlg-S4class.R         +6       0  +100.00%
R/chevron_tlg-S4methods.R      +27      -4  +2.94%
R/cml02a_gl.R                   +8       0  +100.00%
R/cmt01a.R                      -6      -6  +10.34%
R/coxt01.R                      +1       0  +0.04%
R/dmt01.R                       +9       0  +100.00%
R/dst01.R                       -1       0  +100.00%
R/dtht01.R                      -1       0  -0.06%
R/egt02.R                       -2       0  +100.00%
R/egt03.R                       +3       0  +0.05%
R/egt05_qtcat.R                 -1       0  +100.00%
R/ext01.R                       -1       0  -0.03%
R/fstg01.R                      -7       0  +100.00%
R/fstg02.R                      -7       0  +100.00%
R/kmg01.R                       +6      +6  -17.14%
R/lbt01.R                      +59       0  +100.00%
R/lbt04.R                       -1       0  +100.00%
R/lbt05.R                       -1      -3  +4.43%
R/lbt06.R                       -2      -3  +4.17%
R/lbt07.R                       -1       0  +100.00%
R/lbt14.R                       -2       0  +100.00%
R/mht01.R                      -16       0  +100.00%
R/mng01.R                       +1     +11  -11.33%
R/pdt02.R                       -1       0  +100.00%
R/report_null.R                +29       0  +100.00%
R/rmpt01.R                      -6     -10  +15.23%
R/rmpt06.R                    +134      +3  +97.76%
R/rtables_utils.R              +19      +4  -0.88%
R/standard_rules.R              +2       0  +100.00%
R/ttet01.R                      +4       0  +0.08%
R/unwrap.R                     +36       0  +100.00%
R/utils.R                      +94     +13  -7.30%
R/vst02.R                       -1       0  -0.05%
R/zzz.R                         +1      +1  +100.00%
TOTAL                         +425     +16  -0.16%

Results for commit: 6e25f38

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 7, 2025 •
edited
Loading

Unit Tests Summary

  1 files   58 suites   3m 16s ⏱️
293 tests 292 ✅ 1 💤 0 ❌
687 runs  678 ✅ 9 💤 0 ❌

Results for commit 6e25f38.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 7, 2025 •
edited
Loading

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
aet04 💔 $4.10$ $+7.29$ $+8$ $-2$ $0$ $0$
chevron_tlg-methods 💔 $7.69$ $+1.87$ $+5$ $-14$ $0$ $0$
coxt01 💔 $0.51$ $+1.14$ $+6$ $-1$ $0$ $0$
coxt02 💔 $0.67$ $+1.52$ $+6$ $-1$ $0$ $0$
lbt14 💔 $6.95$ $+1.08$ $+4$ $-10$ $0$ $0$
rmpt01 💔 $0.62$ $+1.01$ $+4$ $-3$ $0$ $0$
rspt01 💔 $3.76$ $+3.67$ $+12$ $-7$ $0$ $0$
ttet01 💔 $3.07$ $+2.65$ $+6$ $-4$ $0$ $0$
utils 💔 $0.15$ $+2.17$ $+61$ $-1$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
aet04 💔 $0.79$ $+1.27$ aet04_can_handle_NA_values
aet04 💔 $3.30$ $+6.02$ aet04_can_handle_some_NA_values
coxt01 💔 $0.49$ $+1.15$ coxt01_can_handle_some_NA_values
coxt02 💔 $0.64$ $+1.53$ coxt02_can_handle_some_NA_values
ttet01 💔 $0.69$ $+1.01$ ttet01_works_as_expected_for_stratified_analysis_only
utils 👶 $+0.01$ convert_to_month_warning_messages_as_expected
utils 👶 $+0.02$ convert_to_month_work_as_expected
utils 👶 $+0.01$ do_call_errors_as_expected
utils 👶 $+0.01$ do_call_work_as_expected
utils 👶 $+0.01$ droplevels.character_works_as_expected
utils 👶 $+0.03$ execute_with_args_works_as_expected
utils 👶 $+0.01$ expand_list_works
utils 👶 $+0.01$ format_date_works_as_expected_for_Date
utils 👶 $+0.01$ format_date_works_as_expected_for_POSIXct
utils 👶 $+0.01$ get_section_div_works
utils 👶 $+0.88$ gg_list_is_deprecated
utils 👶 $+0.03$ gg_theme_chevron_works_as_expected
utils 👶 $+0.90$ grob_list_is_deprecated
utils 👶 $+0.01$ lvls.character_works_as_expected
utils 👶 $+0.01$ lvls.default_works_as_expected
utils 👶 $+0.01$ lvls.factor_works_as_expected
utils 👶 $+0.01$ modify_character_works
utils 👶 $+0.01$ modify_default_args_works_as_expected
utils 👶 $+0.01$ quote_str_works_as_expected
utils 👶 $+0.02$ set_section_div_works

Results for commit 98c059f

♻️ This comment has been updated with latest results.

@edelarua edelarua mentioned this pull request Mar 7, 2025
Merged
@shajoezhu
Copy link
Contributor

awesome! So the bug fix looks good here.

shajoezhu pushed a commit to insightsengineering/tern that referenced this pull request Mar 11, 2025
@edelarua @github-actions
Fix analysis function refactor bugs (#1406)
0262e09 
# Pull Request

Fixes #1405 

see checks downstream

- insightsengineering/chevron#829 this is ok now
- https://github.com/insightsengineering/scda.test/pull/189/files this
seems to have numbers changed.

---------

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
shajoezhu
shajoezhu reviewed Mar 11, 2025
View reviewed changes
@shajoezhu
Update DESCRIPTION
6e25f38 
Signed-off-by: Joe Zhu <sha.joe.zhu@gmail.com>
shajoezhu
shajoezhu approved these changes Mar 11, 2025
View reviewed changes
Copy link
Contributor

@shajoezhu shajoezhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@shajoezhu shajoezhu merged commit 54959e2 into main Mar 11, 2025
29 checks passed
@shajoezhu shajoezhu deleted the 1405_afun_refactor_bugs branch March 11, 2025 05:04
@github-actions github-actions bot locked and limited conversation to collaborators Mar 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shajoezhu shajoezhu shajoezhu approved these changes

Assignees
No one assigned
Labels
sme
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edelarua @shajoezhu