Skip to content

fix(all): [LW-8912] fix missing pending txs in activity & stuck infinite scroll on bigger resolutions #696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 2, 2023

Conversation

refi93
Copy link
Contributor

@refi93 refi93 commented Nov 2, 2023

Checklist

  • JIRA - LW-8912
  • Proper tests implemented
  • Screenshots added.

Proposed solution

This PR fixes two independent bugs:

  1. pending txs were incorrectly placed at the bottom of the activity list, resulted in their perceived "disappearance" from activity
  2. while fixing bug 1 I noticed that the activity list remained "stuck" at loading on my screen which appears to be a result of a long-standing bug in the infinite scroll library (Not calling next function on long screens ankeetmaini/react-infinite-scroll-component#380) . A proper fix would probably involve patching the infinite scroll lib or replacing it with a completely different lib. For now I at least documented the bug with a comment and made a workaround to load enough elements to overflow the screen.

Testing

  1. test fix for bug 1 try making a delegation, check that it appears at the top of the "Activity" tab while pending
  2. for bug 2, check that upon initially opening the tab, the activities don't remain stuck in loading state

Screenshots

bug 2: Activity -> stuck loading, especially on full screen, fixed in this PR:

Screenshot 2023-11-02 at 12 39 38


Allure report

allure-report-publisher generated test report!

smokeTests: ❌ test report for b4ec4522

passed failed skipped flaky total result
Total 28 3 0 0 31

@github-actions github-actions bot added the browser Changes to the browser application. label Nov 2, 2023
@refi93 refi93 marked this pull request as ready for review November 2, 2023 11:41
@refi93 refi93 requested a review from a team as a code owner November 2, 2023 11:41
@refi93 refi93 requested review from mrcnk, xdzurman and ljagiela November 2, 2023 11:41
@ljagiela ljagiela enabled auto-merge (squash) November 2, 2023 13:11
@ljagiela ljagiela merged commit 944e16f into main Nov 2, 2023
@ljagiela ljagiela deleted the fix/lw-8912-missing-pending-txs branch November 2, 2023 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser Changes to the browser application.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants