fix(staking): [LW-8912] fix delegations with stake key (de)registrations being omitted from activity #713
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…omitted from activity
Allure report
smokeTests: ✅ test report for a398111a
|
oldGreg5
approved these changes
Nov 8, 2023
mrcnk
approved these changes
Nov 8, 2023
przemyslaw-wlodek
approved these changes
Nov 8, 2023
przemyslaw-wlodek
deleted the
fix/lw-8912-delegations-without-deposit-omitted
branch
danielmain
pushed a commit
that referenced
this pull request
Nov 8, 2023
…omitted from activity (#713)
shawnbusuttil
pushed a commit
that referenced
this pull request
Nov 17, 2023
* feat(staking): [LW-8879] persistence banner fix, minor banners refactor (#702) persistence banner fix, minor banners refactor * feat(extension): update lace version and default release note (#709) * test(extension): test maintenance 7 Nov (#707) * chore(extension): update multi-staking faq (#711) * chore(extension): update multi-staking faq * test(extension): fix LW-8465 --------- Co-authored-by: wklos-iohk <wojciech.klos@iohk.io> * fix(staking): fix delegations with stake key (de)registrations being omitted from activity (#713) * fix: lace crashing for ada handle wallets --------- Co-authored-by: Rafael Korbaš <rafael.korbas@gmail.com> Co-authored-by: Michael Chappell <7581002+mchappell@users.noreply.github.com> Co-authored-by: Lukasz Jagiela <12641433+ljagiela@users.noreply.github.com> Co-authored-by: wklos-iohk <wojciech.klos@iohk.io>
mchappell
added a commit
that referenced
this pull request
Nov 17, 2023
* feat(staking): [LW-8879] persistence banner fix, minor banners refactor (#702) persistence banner fix, minor banners refactor * feat(extension): update lace version and default release note (#709) * test(extension): test maintenance 7 Nov (#707) * chore(extension): update multi-staking faq (#711) * chore(extension): update multi-staking faq * test(extension): fix LW-8465 --------- Co-authored-by: wklos-iohk <wojciech.klos@iohk.io> * fix(staking): fix delegations with stake key (de)registrations being omitted from activity (#713) * fix: lace crashing for ada handle wallets --------- Co-authored-by: Rafael Korbaš <rafael.korbas@gmail.com> Co-authored-by: Michael Chappell <7581002+mchappell@users.noreply.github.com> Co-authored-by: Lukasz Jagiela <12641433+ljagiela@users.noreply.github.com> Co-authored-by: wklos-iohk <wojciech.klos@iohk.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Proposed solution
Turns out ticket LW-8912 actually reported two issues and in #696 we fixed only one of them (pending txs being wrongly at the bottom of the activity list). This PR fixes the other issue which got overlooked, namely that delegation transactions without any stake key (de)registrations were incorrectly transformed to empty events
Testing
Make a delegation that just changes the pools, without changing their amount and check that the respective tx correctly appears in wallet activity
Screenshots
Before
After
