chore(code)!: Remove VoteSet-based synchronization protocol #1008
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romac
changed the title
romac
force-pushed
the
romac/remove-vote-set
branch
from
024dbac to
1ab3417
Compare
|
Looks like GitHub Actions are completely broken at this time. Will re-run CI tomorrow. |
8 tasks
romac
force-pushed
the
romac/remove-vote-set
branch
from
1ab3417 to
5de387d
Compare
romac
changed the title
romac
force-pushed
the
romac/remove-vote-set
branch
from
a70efac to
058acf8
Compare
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #1008 +/- ##
==========================================
- Coverage 77.61% 77.01% -0.60%
==========================================
Files 159 156 -3
Lines 16814 16047 -767
Branches 16814 16047 -767
==========================================
- Hits 13050 12358 -692
+ Misses 2887 2850 -37
+ Partials 877 839 -38
Flags with carried forward coverage won't be shown. Click here to find out more. |
ancazamfir
reviewed
May 8, 2025
| @@ -39,13 +39,11 @@ pub struct Status<Ctx: Context> { | |||
| #[derive_where(Clone, Debug, PartialEq, Eq)] | |||
| pub enum Request<Ctx: Context> { | |||
There was a problem hiding this comment.
Do we still want to keep this enum? Same for Response
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #922 and #998, the VoteSet protocol is neither required nor sufficient for liveness and can therefore be removed 🎉
PR author checklist
For all contributors
RELEASE_NOTES.mdif the change warrants itBREAKING_CHANGES.mdif the change warrants itFor external contributors