Skip to content

chore(code): Remove the time limit related code #1037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 17, 2025

Conversation

ancazamfir
Copy link
Collaborator

Closes: #XXX


PR author checklist

For all contributors

For external contributors

@ancazamfir ancazamfir marked this pull request as ready for review May 17, 2025 03:39
@ancazamfir ancazamfir requested a review from romac as a code owner May 17, 2025 03:39
Copy link

codecov bot commented May 17, 2025

Codecov Report

Attention: Patch coverage is 81.81818% with 2 lines in your changes missing coverage. Please review.

Project coverage is 76.99%. Comparing base (8da04a4) to head (7b51497).
Report is 2 commits behind head on romac/remove-vote-set.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@                    Coverage Diff                    @@
##           romac/remove-vote-set    #1037      +/-   ##
=========================================================
+ Coverage                  76.79%   76.99%   +0.21%     
=========================================================
  Files                        157      156       -1     
  Lines                      16119    16044      -75     
  Branches                   16119    16044      -75     
=========================================================
- Hits                       12377    12353      -24     
+ Misses                      2905     2857      -48     
+ Partials                     837      834       -3     
Flag Coverage Δ
integration 76.79% <81.82%> (+0.21%) ⬆️
mbt 8.37% <0.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ancazamfir ancazamfir merged commit 2e60739 into romac/remove-vote-set May 17, 2025
22 of 23 checks passed
@ancazamfir ancazamfir deleted the anca/remove_time_limit branch May 17, 2025 04:00
5 => TimeoutKind::PrevoteTimeLimit,
6 => TimeoutKind::PrecommitTimeLimit,
7 => TimeoutKind::Rebroadcast,
5 => TimeoutKind::Rebroadcast,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be 7

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in #1008

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants