Skip to content

Adding queue name and change the database schema #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Feb 25, 2025
Merged

Adding queue name and change the database schema #20

merged 9 commits into from
Feb 25, 2025

Conversation

thoven87
Copy link
Contributor

@thoven87 thoven87 commented Feb 23, 2025 •
edited
Loading

  • Adding queue name
  • Migrate the Postgres driver to swift_jobs schema
  • Drop all previous migrations

Renamed the following tables:

  • _hb_pg_job_queue -> swift_jobs.queues
  • _hb_pg_jobs -> swift_jobs.jobs
  • _hb_pg_job_queue_metadata -> swift_jobs.queues_metadata

Renamed the following columns:

  • createdAt -> created_at
  • lastModified -> last_modified

Added new indexes which reflects the current schema.

@thoven87
Conforming to JobQueueDriver
8f6e0e3 
* Conforming to JobQueueDriver with queueName implementation
* Migrate the Postgres driver to `swift_jobs` schema
@thoven87 thoven87 added the enhancement New feature or request label Feb 23, 2025
This was referenced Feb 23, 2025
Closed
Closed
@thoven87 thoven87 changed the title Conforming to JobQueueDriver Adding queue name and change the database schema Feb 23, 2025
@thoven87 thoven87 mentioned this pull request Feb 24, 2025
Merged
adam-fowler
adam-fowler reviewed Feb 24, 2025
View reviewed changes
Copy link
Member

@adam-fowler adam-fowler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general looks good. Not sure we should keep breaking changes details in README. There are a number of breaking changes we have introduced and we should detail those in the release notes.

@thoven87
Copy link
Contributor Author

In general looks good. Not sure we should keep breaking changes details in README. There are a number of breaking changes we have introduced and we should detail those in the release notes.

Noted, I removed the breaking changed notes. I will tag the notes in a breaking changed issue.

adam-fowler
adam-fowler reviewed Feb 24, 2025
View reviewed changes
adam-fowler
adam-fowler reviewed Feb 25, 2025
View reviewed changes
Copy link
Member

@adam-fowler adam-fowler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor thing, but otherwise we are good

@thoven87
Copy link
Contributor Author

One minor thing, but otherwise we are good

I addressed the feedback on the most recent commit.

@adam-fowler adam-fowler merged commit d6a90fc into hummingbird-project:main Feb 25, 2025
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adam-fowler adam-fowler adam-fowler approved these changes

@Joannis Joannis Awaiting requested review from Joannis Joannis is a code owner

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thoven87 @adam-fowler