Skip to content

Make sure we have unique keys per queue for queue metadata #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 24, 2025

Conversation

adam-fowler
Copy link
Member

@adam-fowler adam-fowler commented Feb 23, 2025

Also rename queue keys to use dot notation eg queueName.pending, queueName.metadata.test

Also rename queue keys to use dot notation
Copy link

codecov bot commented Feb 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.73%. Comparing base (b646b55) to head (4d44117).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #24      +/-   ##
==========================================
+ Coverage   89.59%   89.73%   +0.13%     
==========================================
  Files           3        3              
  Lines         221      224       +3     
==========================================
+ Hits          198      201       +3     
  Misses         23       23              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adam-fowler adam-fowler merged commit 8a10b06 into main Feb 24, 2025
8 of 9 checks passed
@adam-fowler adam-fowler deleted the queue-metadata branch February 24, 2025 14:19
@thoven87
Copy link
Contributor

I believe some work is needed to be done in the job scheduler to allow multiple job scheduler per queue. I discovered while working on this PR it does not matter how many scheduler instances that's created, there will always be one scheduler metadata in the table. The first queue name will be picked up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants