Skip to content

Improved : Improve User Feedback When Lacking Commerce_View Permission (launchpad-132) #834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Improved : Improve User Feedback When Lacking Commerce_View Permission (launchpad-132) #834

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/authorization/Actions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,6 @@ export default {
"APP_STORE_PERMISSIONS_VIEW": "APP_STORE_PERMISSIONS_VIEW",
"APP_SETTINGS_VIEW": "APP_SETTINGS_VIEW",
"APP_COUNT_VIEW": "APP_COUNT_VIEW",
"APP_PRODUCT_IDENTIFIER_UPDATE": "APP_PRODUCT_IDENTIFIER_UPDATE"
"APP_PRODUCT_IDENTIFIER_UPDATE": "APP_PRODUCT_IDENTIFIER_UPDATE",
"APP_COMMERCE_VIEW": "APP_COMMERCE_VIEW"
}
3 changes: 2 additions & 1 deletion src/authorization/Rules.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,6 @@ export default {
"APP_SETTINGS_VIEW": "",
"APP_COUNT_VIEW": "FULFILL_INVCUNT_ADMIN OR INV_COUNT_ADMIN",
"APP_PRODUCT_IDENTIFIER_UPDATE": "COMMON_ADMIN",
"INVCOUNT_APP_VIEW": "INVCOUNT_APP_VIEW"
"INVCOUNT_APP_VIEW": "INVCOUNT_APP_VIEW",
"APP_COMMERCE_VIEW": "COMMERCEUSER_VIEW"
} as any
2 changes: 1 addition & 1 deletion src/views/Settings.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
<ion-card-content>
{{ $t('This is the name of the OMS you are connected to right now. Make sure that you are connected to the right instance before proceeding.') }}
</ion-card-content>
<ion-button v-if="!authStore.isEmbedded" :disabled="!omsRedirectionInfo.token || !omsRedirectionInfo.url" @click="goToOms(omsRedirectionInfo.token, omsRedirectionInfo.url)" fill="clear">
<ion-button v-if="!authStore.isEmbedded" :disabled="!omsRedirectionInfo.token || !omsRedirectionInfo.url || !hasPermission(Actions.APP_COMMERCE_VIEW)" @click="goToOms(omsRedirectionInfo.token, omsRedirectionInfo.url)" fill="clear">
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For better readability and maintainability, consider extracting the logic for the :disabled attribute into a computed property. This keeps the template cleaner and centralizes the logic in the script section.

You could add a computed property like this in your <script setup>:

const isGoToOmsDisabled = computed(() => {
  return !omsRedirectionInfo.value.token || !omsRedirectionInfo.value.url || !hasPermission(Actions.APP_COMMERCE_VIEW);
});

And then use it in the template:

<ion-button ... :disabled="isGoToOmsDisabled" ...>

{{ $t('Go to OMS') }}
<ion-icon slot="end" :icon="openOutline" />
</ion-button>
Expand Down
Loading