Improved : Improve User Feedback When Lacking Commerce_View Permission (launchpad-132)

[Nirvan-Bobde30]

Related Issues

hotwax/launchpad#132

Short Description and Why It's Useful

• added check to disable goto oms button if commerce_app permission is not given.

Screenshots of Visual Changes before/after (If There Are Any)

Contribution and Currently Important Rules Acceptance

• I have read and followed contribution rules

[gemini-code-assist]

Summary of Changes

Hello @Nirvan-Bobde30, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances user experience by providing clearer feedback regarding access to the Order Management System (OMS). It introduces a new permission check that disables the 'Go to OMS' button in the settings if the user lacks the required COMMERCEUSER_VIEW permission. This prevents unauthorized access attempts and improves the interface by indicating unavailable actions upfront, addressing the issue of unclear user feedback.

Highlights

• New Permission Action: A new permission action, APP_COMMERCE_VIEW, has been introduced to explicitly define the ability to view commerce-related functionalities.
• Permission Rule Mapping: The APP_COMMERCE_VIEW action is now mapped to the COMMERCEUSER_VIEW permission rule, ensuring that users require this specific permission to access commerce views.
• Improved User Feedback: The 'Go to OMS' button in the Settings view is now conditionally disabled based on the user's APP_COMMERCE_VIEW permission, preventing users without the necessary access from attempting to navigate to the OMS.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly implements the intended feature of disabling the 'Go to OMS' button when the user lacks the APP_COMMERCE_VIEW permission. The changes are well-contained, adding the new action and its corresponding rule, and then applying the permission check in the UI. I have one suggestion in src/views/Settings.vue to improve code readability by moving the complex condition for the button's disabled state into a computed property. This will make the template cleaner and the logic easier to maintain.

[gemini-code-assist]

For better readability and maintainability, consider extracting the logic for the :disabled attribute into a computed property. This keeps the template cleaner and centralizes the logic in the script section.

You could add a computed property like this in your <script setup>:

const isGoToOmsDisabled = computed(() => {
  return !omsRedirectionInfo.value.token || !omsRedirectionInfo.value.url || !hasPermission(Actions.APP_COMMERCE_VIEW);
});

And then use it in the template:

<ion-button ... :disabled="isGoToOmsDisabled" ...>