Skip to content

Conversation

justinwilaby
Copy link
Contributor

@justinwilaby justinwilaby commented Mar 18, 2025

This PR brings the security vulns to zero.

Code changes are minimal and low risk but regressions cannot be ruled out. Testing will be conducted by Matt Blewitt's team.

W-18063165

@justinwilaby justinwilaby requested a review from a team as a code owner March 18, 2025 13:36
Copy link

@k80bowman k80bowman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks OK, though I have added a few questions. I also noticed that this PR does not just update dependencies, you also switched from yarn to npm. Has this been tested? Do we know that it works? I would like to be sure of that before I approve.

@justinwilaby justinwilaby force-pushed the jw/security-updates branch 2 times, most recently from 7fc52ef to fe35b76 Compare March 18, 2025 18:07
@justinwilaby justinwilaby requested a review from k80bowman March 18, 2025 18:08
@k80bowman k80bowman dismissed their stale review March 20, 2025 18:41

Unblocking since the switch from yarn to npm was removed.

Copy link
Contributor

@eablack eablack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@eablack eablack merged commit 139c202 into main Mar 28, 2025
2 checks passed
@eablack eablack deleted the jw/security-updates branch March 28, 2025 18:16
@eablack eablack mentioned this pull request Apr 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants