Skip to content

Conversation

PaulyFleming
Copy link
Contributor

@PaulyFleming PaulyFleming commented Mar 11, 2025

This makes a change so that the kafka default retention time on a new topic is handled by the default_retention_time and not the minimum_retention_time.

This PR pairs up with this PR that changes the minimum allowed retention time on Kafka topics to 6 hours (from 24) while keeping the default retention time for new topics at 24 hours.

Change Proposal: https://salesforce.quip.com/7fCdA7EZb7Gg

heroku kafka:topics:create topic-moose HEROKU_KAFKA_PFLEMING_PUCE -a pfleming-kafka-us
Creating topic topic-moose with compaction disabled and retention time 1 day on kafka-pfleming-silhouetted-42102... done
Use `heroku kafka:topics:info topic-moose` to monitor your topic.

heroku kafka:topics:retention-time topic-moose '6 hours' HEROKU_KAFKA_PFLEMING_PUCE -a pfleming-kafka-us 
Setting retention time to 6 hours for topic topic-moose on kafka-pfleming-silhouetted-42102... done
Use `heroku kafka:topics:info topic-moose` to monitor your topic.

heroku kafka:topics:retention-time topic-moose '8 hours' HEROKU_KAFKA_PFLEMING_PUCE -a pfleming-kafka-us 
Setting retention time to 8 hours for topic topic-moose on kafka-pfleming-silhouetted-42102... done
Use `heroku kafka:topics:info topic-moose` to monitor your topic.

@PaulyFleming PaulyFleming requested a review from a team as a code owner March 11, 2025 15:19
Copy link
Contributor

@sbosio sbosio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review the comment I left, there seems to be a typo on the changed line. But overall looks ok, so I'm approving.

Co-authored-by: Santiago Bosio <santiago.bosio@gmail.com>
Signed-off-by: PaulyFleming <56516379+PaulyFleming@users.noreply.github.com>
@PaulyFleming
Copy link
Contributor Author

Thank you @sbosio & good catch on the double assignment typo!

Copy link
Contributor

@justinwilaby justinwilaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PaulyFleming PaulyFleming changed the title Let the kakfa cli pugin use the default retention time Let the kakfa cli plugin use the default retention time Mar 20, 2025
Signed-off-by: PaulyFleming <56516379+PaulyFleming@users.noreply.github.com>
@eablack eablack merged commit 8d452da into main Apr 8, 2025
2 checks passed
@eablack eablack deleted the pf/kafka_cli_uses_default_retention_value branch April 8, 2025 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants