-
Notifications
You must be signed in to change notification settings - Fork 3
fix(mod): better logging for 1.7.10, default to github caching #74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
3arthqu4ke
wants to merge
6
commits into
main
Choose a base branch
from
73-investigate-caches
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
337f120
fix(mod): Better logging for 1.7.10
3arthqu4ke 5a761fe
chore(docs): Document use of blacksmith for caching
3arthqu4ke dc1c3e2
chore: disable cache by default
ChipWolf fbd814d
Update 1_7_10/src/main/java/me/earth/mc_runtime_test/mixin/MixinNetwo…
ChipWolf 4624f28
chore(docs): capitalisation nitpick
ChipWolf 8e2ccc9
chore(docs): Make cache step configurable, default to github cache
3arthqu4ke File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
37 changes: 37 additions & 0 deletions
37
1_7_10/src/main/java/me/earth/mc_runtime_test/mixin/MixinNetworkManager.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
package me.earth.mc_runtime_test.mixin; | ||
|
||
import io.netty.channel.ChannelHandlerContext; | ||
import io.netty.util.concurrent.GenericFutureListener; | ||
import net.minecraft.network.NetworkManager; | ||
import net.minecraft.network.Packet; | ||
import org.apache.logging.log4j.Logger; | ||
import org.spongepowered.asm.mixin.Final; | ||
import org.spongepowered.asm.mixin.Mixin; | ||
import org.spongepowered.asm.mixin.Shadow; | ||
import org.spongepowered.asm.mixin.injection.At; | ||
import org.spongepowered.asm.mixin.injection.Inject; | ||
import org.spongepowered.asm.mixin.injection.callback.CallbackInfo; | ||
|
||
@Mixin(NetworkManager.class) | ||
@SuppressWarnings("StringConcatenationArgumentToLogCall") | ||
public class MixinNetworkManager { | ||
@Shadow | ||
@Final | ||
private static Logger logger; | ||
|
||
@Inject(method = "scheduleOutboundPacket", at = @At("HEAD")) | ||
protected void scheduleOutboundPacketHook(Packet packet, GenericFutureListener<?>[] futureListeners, CallbackInfo ci) { | ||
logger.info("Sending packet: " + packet.getClass().getName()); | ||
} | ||
|
||
@Inject(method = "channelRead0", at = @At("HEAD")) | ||
protected void channelRead0Hook(ChannelHandlerContext context, Packet packet, CallbackInfo ci) { | ||
logger.info("Packet received: " + packet.getClass().getName()); | ||
ChipWolf marked this conversation as resolved.
Show resolved
Hide resolved
3arthqu4ke marked this conversation as resolved.
Show resolved
Hide resolved
|
||
} | ||
|
||
@Inject(method = "exceptionCaught", at = @At("HEAD")) | ||
private void exceptionCaughtHook(ChannelHandlerContext context, Throwable throwable, CallbackInfo ci) { | ||
3arthqu4ke marked this conversation as resolved.
Show resolved
Hide resolved
|
||
logger.error("Exception caught", throwable); | ||
} | ||
|
||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.