-
Notifications
You must be signed in to change notification settings - Fork 3
fix(mod): better logging for 1.7.10, default to github caching #74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR improves logging for Minecraft 1.7.10 by adding a new NetworkManager mixin and adjusts the default caching behavior along with corresponding documentation and workflow updates.
- Change
cache-mc
default fromtrue
tofalse
in the GitHub Action - Add a Caching section to the README for enabling
.minecraft
caching - Introduce
MixinNetworkManager
to log outbound/inbound packets and exceptions - Update workflows to respect the new
cache-mc
input
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
File | Description |
---|---|
action.yml | Changed cache-mc default to false |
README.md | Added "## Caching" section explaining cache-mc usage |
1_7_10/src/main/resources/mc_runtime_test.mixins.json | Registered new MixinNetworkManager in the mixin config |
1_7_10/src/main/java/me/earth/mc_runtime_test/mixin/MixinNetworkManager.java | Added logging hooks for packet send/receive and exceptions |
.github/workflows/test-local-action.yml | Removed hardcoded cache-mc override |
.github/workflows/run-gametests.yml | Enabled cache-mc: "true" for game test runs |
.github/workflows/lifecycle.yml | Enabled cache-mc: "true" in lifecycle workflow |
1_7_10/src/main/java/me/earth/mc_runtime_test/mixin/MixinNetworkManager.java
Outdated
Show resolved
Hide resolved
1_7_10/src/main/java/me/earth/mc_runtime_test/mixin/MixinNetworkManager.java
Outdated
Show resolved
Hide resolved
…rkManager.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refines caching behavior by changing the default for cache-mc
, adds a new mixin to improve packet logging in MC 1.7.10, and updates docs and workflows to reflect these changes.
- Default
cache-mc
input flipped to false; workflows updated to opt in/out. - New
MixinNetworkManager
mixin logs outbound, inbound, and exception events. - README gains a “Caching” section with setup instructions.
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 5 comments.
Show a summary per file
File | Description |
---|---|
action.yml | Changed default cache-mc from "true" to "false" |
README.md | Added “Caching” section with Blacksmith instructions |
1_7_10/src/main/resources/mc_runtime_test.mixins.json | Registered new MixinNetworkManager mixin |
1_7_10/src/main/java/me/earth/mc_runtime_test/mixin/MixinNetworkManager.java | Implemented packet and error logging injections |
.github/workflows/test-local-action.yml | Removed hardcoded cache-mc override |
.github/workflows/run-gametests.yml | Enabled caching via cache-mc: "true" |
.github/workflows/lifecycle.yml | Enabled caching via cache-mc: "true" |
1_7_10/src/main/java/me/earth/mc_runtime_test/mixin/MixinNetworkManager.java
Show resolved
Hide resolved
1_7_10/src/main/java/me/earth/mc_runtime_test/mixin/MixinNetworkManager.java
Show resolved
Hide resolved
1_7_10/src/main/java/me/earth/mc_runtime_test/mixin/MixinNetworkManager.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates caching defaults and enhances logging for Minecraft 1.7.10 network packets.
- Changed
cache-mc
default tofalse
and re-enabled it in CI workflows where needed - Added a new
MixinNetworkManager
mixin and corresponding JSON entry to log outbound/inbound packets and exceptions - Extended README with a new Caching section describing how to enable
.minecraft
caching
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
File | Description |
---|---|
action.yml | Changed default of cache-mc from "true" to "false" |
README.md | Added a Caching section explaining how to enable the cache-mc input |
1_7_10/src/main/resources/mc_runtime_test.mixins.json | Added "MixinNetworkManager" to mixin list |
1_7_10/src/main/java/me/earth/mc_runtime_test/mixin/MixinNetworkManager.java | Introduced packet logging and exception hooks via mixins |
.github/workflows/test-local-action.yml | Removed hardcoded cache-mc: false to rely on new default |
.github/workflows/run-gametests.yml | Explicitly set cache-mc: "true" for game-test runs |
.github/workflows/lifecycle.yml | Enabled cache-mc: "true" in lifecycle jobs |
Comments suppressed due to low confidence (1)
1_7_10/src/main/java/me/earth/mc_runtime_test/mixin/MixinNetworkManager.java:22
- [nitpick] This new logging hook isn’t covered by existing tests; consider adding an integration or unit test to verify that packet logging behaves as expected.
@Inject(method = "scheduleOutboundPacket", at = @At("HEAD"))
1_7_10/src/main/java/me/earth/mc_runtime_test/mixin/MixinNetworkManager.java
Show resolved
Hide resolved
1_7_10/src/main/java/me/earth/mc_runtime_test/mixin/MixinNetworkManager.java
Show resolved
Hide resolved
@ChipWolf defaults to github cache now, but blacksmith is configurable. |
Related: #23