Skip to content

fix: set region to nil if trees are empty #478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

fix: set region to nil if trees are empty #478

wants to merge 1 commit into from

Conversation

choffmann
Copy link
Member

Close #472

@choffmann choffmann self-assigned this Mar 29, 2025
@choffmann choffmann added the need-reviewer Send notification in Discord label Mar 29, 2025
@choffmann choffmann mentioned this pull request Mar 29, 2025
Merged
@xk0niR xk0niR self-requested a review March 29, 2025 23:28
xk0niR
xk0niR requested changes Mar 29, 2025
View reviewed changes
Copy link
Contributor

@xk0niR xk0niR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still get this error.

After applying seed data:

  • Create treecluster A with tree 1030 (only yellow one)
  • Create treecluster B with tree 1030 (only yellow one), stealing from A.

=> A still shows Jürgensby as region without any tree.

@choffmann choffmann marked this pull request as draft April 2, 2025 14:33
@choffmann choffmann force-pushed the develop branch 6 times, most recently from e1caf75 to 658e8d9 Compare May 1, 2025 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xk0niR xk0niR xk0niR requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@choffmann choffmann

Labels
need-reviewer Send notification in Discord
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tree cluster without trees still has a region
2 participants
@choffmann @xk0niR