Skip to content

feat: recalculate cluster watering status #477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 30, 2025

Conversation

choffmann
Copy link
Member

Close #473

@choffmann choffmann added the need-reviewer Send notification in Discord label Mar 29, 2025
@choffmann choffmann self-assigned this Mar 29, 2025
@xk0niR
Copy link
Contributor

xk0niR commented Mar 29, 2025

I have tested this successfully as described in #473 . build_and_test is failing as seeing above. Can you check this @choffmann ?
Also I noticed another bug (not related to this PR): Region is not being updated properly as seen in this screenshot.
grafik

EDIT: The issue is already mentioned in #472

@choffmann choffmann force-pushed the feature/recalculate-cluster-watering-status branch from 2ba0106 to 3d8c50b Compare March 29, 2025 21:29
@choffmann
Copy link
Member Author

I have tested this successfully as described in #473 . build_and_test is failing as seeing above. Can you check this @choffmann ?

@xk0niR done!

@choffmann
Copy link
Member Author

choffmann commented Mar 29, 2025

EDIT: The issue is already mentioned in #472

@xk0niR see #478

@xk0niR xk0niR self-requested a review March 29, 2025 23:16
Copy link
Contributor

@xk0niR xk0niR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@choffmann choffmann force-pushed the feature/recalculate-cluster-watering-status branch from 3d8c50b to f83c949 Compare March 30, 2025 11:04
@choffmann choffmann merged commit 5fd70a4 into develop Mar 30, 2025
4 checks passed
@choffmann choffmann deleted the feature/recalculate-cluster-watering-status branch March 30, 2025 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need-reviewer Send notification in Discord
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Watering status is not updated on tree cluster create
2 participants