Update plugin to use Apache Grails maven coordinates + other updates #244
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,2 @@ | ||
| # Enable auto-env through the sdkman_auto_env config - https://sdkman.io/usage#env | ||
| java=17.0.15-librca |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,39 +1,42 @@ | ||
| buildscript { | ||
| repositories { | ||
| maven { url = "https://repository.apache.org/content/groups/snapshots/" } | ||
| maven { url = "https://repo.grails.org/grails/core" } | ||
| } | ||
| dependencies { | ||
| classpath platform("org.apache.grails:grails-bom:$grailsVersion") | ||
| classpath "org.apache.grails:grails-gradle-plugins" | ||
| classpath "com.bertramlabs.plugins:asset-pipeline-gradle" | ||
| } | ||
| } | ||
|
|
||
| allprojects { | ||
| repositories { | ||
| mavenCentral() | ||
| maven { url = "https://repository.apache.org/content/groups/snapshots/" } | ||
| maven { url = 'https://repo.grails.org/grails/core' } | ||
| // mavenLocal() // for local testing, do not commit uncommented | ||
| } | ||
| } | ||
|
|
||
| version = project.projectVersion | ||
| group = "org.grails.plugins" | ||
|
|
||
| subprojects { Project project -> | ||
| project.version = project.projectVersion | ||
| project.group = "org.grails.plugins" | ||
|
|
||
| if(project.name.endsWith('audit-logging')) { | ||
| apply plugin: "org.apache.grails.gradle.grails-publish" | ||
| grailsPublish { | ||
| githubSlug = 'grails-plugins/grails-audit-logging-plugin' | ||
| license { | ||
| name = 'Apache-2.0' | ||
| } | ||
| title = "Grails Audit-Logging Plugin" | ||
| desc = "Grails Audit-Logging Plugin for Grails 7+" | ||
| developers = [robertoschwald:"Robert Oschwald", longwa:"Aaron Long", elkr:"Elmar Kretzer", | ||
| jamesfredley:"James Fredley", jdaugherty:"James Daugherty"] | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/apache/grails-core/blob/7.0.x/UPGRADE7.md#common-70-upgrade-gotchas---draft--
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we used to recommend ehcache by default; is this actually used in the project?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The dependency was not listed in the
build.gradlefiles, but was being loaded based on: https://github.com/grails-plugins/grails-audit-logging-plugin/blob/apache-coordinate-updates/examples/audit-test-allow-update-outside-transaction/grails-app/conf/application.yml#L80 which was putting the non-jakarta version of hibernate5 on the classpath and causing method not found errors.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
apache/grails-core#14721