Update plugin to use Apache Grails maven coordinates + other updates #244
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Apache coordinate configurations by introducing a second datasource configuration in the development environment.
- Adds a new "dataSources" block for a secondary datasource with update behavior.
- Maintains separate configurations for the test environment.
Files not reviewed (13)
- .envrc: Language not supported
- .sdkmanrc: Language not supported
- examples/audit-test-allow-update-outside-transaction/build.gradle: Language not supported
- examples/audit-test/build.gradle: Language not supported
- examples/audit-test/grails-app/views/error.gsp: Language not supported
- flake.nix: Language not supported
- gradle.properties: Language not supported
- gradle/wrapper/gradle-wrapper.properties: Language not supported
- gradlew: Language not supported
- gradlew.bat: Language not supported
- plugin/build.gradle: Language not supported
- plugin/src/main/groovy/grails/plugins/orm/auditable/Auditable.groovy: Language not supported
- settings.gradle: Language not supported
| implementation "org.apache.grails:grails-gsp" | ||
| implementation "org.apache.grails:grails-data-hibernate5" | ||
|
|
||
| implementation "org.hibernate:hibernate-ehcache:$hibernate5Version", { |
There was a problem hiding this comment.
There was a problem hiding this comment.
we used to recommend ehcache by default; is this actually used in the project?
There was a problem hiding this comment.
The dependency was not listed in the build.gradle files, but was being loaded based on: https://github.com/grails-plugins/grails-audit-logging-plugin/blob/apache-coordinate-updates/examples/audit-test-allow-update-outside-transaction/grails-app/conf/application.yml#L80 which was putting the non-jakarta version of hibernate5 on the classpath and causing method not found errors.
There was a problem hiding this comment.
| implementation "org.apache.grails:grails-gsp" | ||
| implementation "org.apache.grails:grails-data-hibernate5" | ||
|
|
||
| implementation "org.hibernate:hibernate-ehcache:$hibernate5Version", { |
There was a problem hiding this comment.
examples/audit-test-allow-update-outside-transaction/grails-app/conf/application.yml
Show resolved
Hide resolved
| @@ -1 +0,0 @@ | |||
| use flake | |||
There was a problem hiding this comment.
Removed all of flake config, since we do not use it on Grails projects
jamesfredley
changed the title
-remove flake config since we are not using flake
-Fix left over javax references
-Apache Grails coordinate updates plus add Apache snapshot repository
-Add ehcache dependency config to prevent hibernate-core non-jakarta dependency
-Gradle 8.14
-Update develocity config