Add support for service account impersonation #12
+188
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
andrewnicolalde
commented
May 9, 2025
| func (source *impersonatedGceSource) getToken(ctx context.Context) (*oauth2.Token, error) { | ||
| tokenSource, err := impersonate.CredentialsTokenSource(ctx, impersonate.CredentialsConfig{ | ||
| TargetPrincipal: source.TargetPrincipal, | ||
| Scopes: []string{"https://www.googleapis.com/auth/cloud-platform.read-only"}, |
There was a problem hiding this comment.
Perhaps the value of Scopes should actually be cfg.Scopes or source.scopes
|
I'll do some house keeping and then the go.mod changes won't be necessary. |
Thanks! Feel free to change this PR. |
|
@zoltanbedi Let me know if you have any feedback! Happy to make the requisite changes myself, if there are any 🫡 . |
|
Hey @andrewnicolalde, I checked your branch and did some changes but I still want to verify it and try it out. |
zoltanbedi
added a commit
that referenced
this pull request
May 23, 2025
|
I'm going to close this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Superseded by #14
This PR adds support for service account impersonation.Note: I have not been able to get a binary written to disk so that I can test that these changes produce the desired result. If you have any advice as to how I can do so, that would be much appreciated!See also: grafana/google-bigquery-datasource#336