Skip to content

Add support for service account impersonation #336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

andrewnicolalde
Copy link

@andrewnicolalde andrewnicolalde commented May 7, 2025

This PR adds support for service account impersonation. It depends on the changes introduced in grafana/grafana-google-sdk-go#12

Note: I have not been able to get a binary built and written to disk so that I can test that these changes produce the desired result. If you have any advice as to how I can do so, that would be much appreciated!

TODO: Make changes to configuration web page to allow configuration via Grafana UI.

@andrewnicolalde andrewnicolalde requested a review from a team as a code owner May 7, 2025 09:59
@CLAassistant
Copy link

CLAassistant commented May 7, 2025

CLA assistant check
All committers have signed the CLA.

@zoltanbedi
Copy link
Member

Thanks for creating this PR @andrewnicolalde can you please sign the cla?

@andrewnicolalde
Copy link
Author

@zoltanbedi I have now signed the CLA 😃.

@zoltanbedi
Copy link
Member

@andrewnicolalde thanks. I'll take a look at your other PR first in the sdk repository.

@andrewnicolalde
Copy link
Author

@zoltanbedi Now that we've added support for service account impersonation in grafana-google-sdk-go, what remains to be done to get a new version of this plugin released?

I know for certain that we need to add SA impersonation options to the configuration web pages for the plugin so that it can be configured through the Grafana UI.

@zoltanbedi
Copy link
Member

The data source config needs a new option in https://github.com/grafana/grafana-google-sdk-react. I'm on it, going to open a PR soon. Once that is merged and released we can merge this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants