Skip to content

chore: Restore add_auth_token(s) as deprecated for backward compatibility #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 55 commits into from
May 16, 2025

Conversation

anubhav756
Copy link
Contributor

@anubhav756 anubhav756 commented May 10, 2025

This PR addresses a breaking change introduced by the removal of add_auth_token(s) methods in #182. To ensure backward compatibility and facilitate a smoother upgrade path, these methods are now reintroduced but explicitly marked as deprecated. Users are encouraged to migrate to the new add_auth_token_getter(s) methods instead.

Note

The strict flag in the deprecated methods are not used anymore since the functionality of the strict flag has been changed (see #205 for more details).

@anubhav756 anubhav756 self-assigned this May 10, 2025
@anubhav756 anubhav756 requested a review from a team as a code owner May 10, 2025 04:58
@anubhav756 anubhav756 changed the title chore: Restore add_auth_token(s) as deprecated for backward compatibi… chore: Restore add_auth_token(s) as deprecated for backward compatibility May 10, 2025
@anubhav756 anubhav756 force-pushed the anubhav-lc-wraps-core branch from b229394 to 6ef6e62 Compare May 10, 2025 05:25
@anubhav756 anubhav756 force-pushed the anubhav-deprecate-add-auth-token branch from 585288a to ccbebfa Compare May 10, 2025 05:32
@anubhav756 anubhav756 force-pushed the anubhav-lc-wraps-core branch from 6ef6e62 to ffdedf9 Compare May 12, 2025 14:14
@anubhav756 anubhav756 force-pushed the anubhav-deprecate-add-auth-token branch from ccbebfa to 6c721f7 Compare May 12, 2025 14:14
@anubhav756 anubhav756 force-pushed the anubhav-lc-wraps-core branch from ffdedf9 to bd696b5 Compare May 14, 2025 12:35
@anubhav756 anubhav756 force-pushed the anubhav-deprecate-add-auth-token branch 2 times, most recently from e25a8a1 to fd0c947 Compare May 14, 2025 12:42
@anubhav756 anubhav756 force-pushed the anubhav-lc-wraps-core branch from bd696b5 to 3465dd9 Compare May 14, 2025 12:42
@anubhav756 anubhav756 force-pushed the anubhav-deprecate-add-auth-token branch 5 times, most recently from f43c150 to 25226d1 Compare May 15, 2025 08:43
@anubhav756 anubhav756 force-pushed the anubhav-deprecate-add-auth-token branch from 25226d1 to 9954139 Compare May 15, 2025 11:33
@anubhav756 anubhav756 force-pushed the anubhav-lc-wraps-core branch from 4c73dd0 to 28f3221 Compare May 16, 2025 15:44
@anubhav756 anubhav756 force-pushed the anubhav-deprecate-add-auth-token branch from 9954139 to dd061af Compare May 16, 2025 15:44
@anubhav756 anubhav756 force-pushed the anubhav-lc-wraps-core branch from 28f3221 to 993cf7e Compare May 16, 2025 15:48
@anubhav756 anubhav756 force-pushed the anubhav-deprecate-add-auth-token branch from dd061af to 6818556 Compare May 16, 2025 15:49
@anubhav756 anubhav756 force-pushed the anubhav-lc-wraps-core branch from e8ec4f4 to 0b7b3f9 Compare May 16, 2025 16:50
@anubhav756 anubhav756 force-pushed the anubhav-deprecate-add-auth-token branch from 6818556 to 0c74ce6 Compare May 16, 2025 16:50
@anubhav756 anubhav756 force-pushed the anubhav-lc-wraps-core branch from 0b7b3f9 to fef11af Compare May 16, 2025 20:35
@anubhav756 anubhav756 force-pushed the anubhav-deprecate-add-auth-token branch from 0c74ce6 to 109bf37 Compare May 16, 2025 20:35
@anubhav756 anubhav756 force-pushed the anubhav-lc-wraps-core branch from fef11af to a128a8e Compare May 16, 2025 20:57
@anubhav756 anubhav756 force-pushed the anubhav-lc-wraps-core branch from a128a8e to 9bfb8d1 Compare May 16, 2025 21:24
…lity

This PR addresses a breaking change introduced by the removal of `add_auth_token(s)` methods in #182. To ensure backward compatibility and facilitate a smoother upgrade path, these methods are now reintroduced but explicitly marked as **deprecated**. Users are encouraged to migrate to the new `add_auth_token_getter(s)` methods instead.

> [!NOTE]
> The `strict` flag in the deprecated methods are not used anymore since the functionality of the `strict` flag has been changed (see #205 for more details).
@anubhav756 anubhav756 force-pushed the anubhav-deprecate-add-auth-token branch from 722e436 to faa9d68 Compare May 16, 2025 22:04
Base automatically changed from anubhav-lc-wraps-core to main May 16, 2025 22:06
@anubhav756 anubhav756 merged commit fcdfdae into main May 16, 2025
19 checks passed
@anubhav756 anubhav756 deleted the anubhav-deprecate-add-auth-token branch May 16, 2025 22:14
@release-please release-please bot mentioned this pull request May 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants