-
Notifications
You must be signed in to change notification settings - Fork 15
feat(toolbox-langchain)!: Base toolbox-langchain over toolbox-core #229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d6753ea
to
7e299e3
Compare
8b8c8ea
to
10dfe8c
Compare
e5d1d94
to
854c9df
Compare
c294769
to
56c7c2d
Compare
b229394
to
6ef6e62
Compare
204a6f5
to
64f214c
Compare
6ef6e62
to
ffdedf9
Compare
kurtisvg
requested changes
May 12, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For breaking changes, let's make sure we call out what steps are required to migrate before hand. It's not clear to me which API is breaking here.
Ideally, we want this to be a non-breaking change. Is that possible?
64f214c
to
047b827
Compare
ffdedf9
to
bd696b5
Compare
047b827
to
e7178f9
Compare
bd696b5
to
3465dd9
Compare
a128a8e
to
9bfb8d1
Compare
kurtisvg
approved these changes
May 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new dependency on the foundational library
toolbox-core
.Breaking Changes
This PR introduces changes to how "strictness" is handled across several toolbox functions. The
strict
flag has been removed fromload_tool
,aload_tool
,add_auth_token_getter(s)
, andbind_param(s)
. Additionally, the default behavior ofload_toolset
forstrict=False
has changed.Why?
Enforces more explicit error handling and reduce ambiguity, particularly in scenarios where unused configurations might otherwise be silently ignored.
*
(a)load_tool
do not supportstrict
flag now:Before
After
*
(a)load_toolset
functionality changes forstrict=False
Before
Does not throw error if none of the loaded tools use a given auth token getter or bound param. Only throws a warning.
After
Throws error if none of the loaded tools use a given auth token getter or bound param.
*
add_auth_token_getter(s)
do not supportstrict
flagBefore
After
*
bind_param(s)
do not supportstrict
flagBefore
After