fix: Ensure __parse_tool returns correct used_auth_keys
#204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anubhav756
force-pushed
the
anubhav-used-params
branch
from
4995d2f to
8b5e777
Compare
anubhav756
force-pushed
the
anubhav-fix-used-params
branch
from
e5763b9 to
be9ec4b
Compare
anubhav756
force-pushed
the
anubhav-used-params
branch
from
8b5e777 to
ef02615
Compare
anubhav756
force-pushed
the
anubhav-fix-used-params
branch
from
be9ec4b to
2e36f66
Compare
anubhav756
force-pushed
the
anubhav-used-params
branch
from
ef02615 to
684f744
Compare
anubhav756
force-pushed
the
anubhav-fix-used-params
branch
from
2e36f66 to
ea1a66b
Compare
kurtisvg
approved these changes
May 8, 2025
anubhav756
force-pushed
the
anubhav-used-params
branch
from
684f744 to
e96a22f
Compare
anubhav756
force-pushed
the
anubhav-fix-used-params
branch
from
ea1a66b to
f3e7df1
Compare
anubhav756
force-pushed
the
anubhav-used-params
branch
from
e96a22f to
4738f4d
Compare
anubhav756
force-pushed
the
anubhav-fix-used-params
branch
from
f3e7df1 to
f56cc68
Compare
We will remove this once we actually implement the `strict` flag and centralize this functionality by moving this check to the tool's constructor in a future PR.
anubhav756
force-pushed
the
anubhav-fix-used-params
branch
from
f56cc68 to
6ff0142
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors
__parse_toolto accurately determine and return theused_auth_keysvalue.Investigation revealed that the previously incorrect value was not referenced elsewhere, meaning this bug did not manifest as an active issue. However, this correction enhances the reliability of
__parse_toolfor any future use cases.Note
Unit tests for the underlying helper function that identifies these used auth keys, including tests for the correct values, had already been added in #203. As this PR's change corrects a value that wasn't actively tested or used, no unit test modifications are needed here.