fix: Ensure __parse_tool returns correct used_auth_keys (#204)

anubhav756 · web-flow · commit d0b5020dceca · 2025-05-12T18:34:28.000+05:30
* fix: Add the no parameter check back again.

We will remove this once we actually implement the `strict` flag and centralize this functionality by moving this check to the tool's constructor in a future PR.

* fix: Reverse the error conditions to avoid masking of the second error.

* fix: Fix the identification of used auth services while tool parsing.
diff --git a/packages/toolbox-core/src/toolbox_core/client.py b/packages/toolbox-core/src/toolbox_core/client.py
@@ -79,7 +79,7 @@ def __parse_tool(
             else:  # regular parameter
                 params.append(p)
 
-        authn_params, _ = identify_required_authn_params(
+        authn_params, used_auth_keys = identify_required_authn_params(
             authn_params, auth_token_getters.keys()
         )
 
@@ -97,9 +97,6 @@ def __parse_tool(
         )
 
         used_bound_keys = set(bound_params.keys())
-        used_auth_keys: set[str] = set()
-        for required_sources in authn_params.values():
-            used_auth_keys.update(required_sources)
 
         return tool, used_auth_keys, used_bound_keys
 

Original file line number	Diff line number	Diff line change
`@@ -79,7 +79,7 @@ def __parse_tool(`
`79`	`79`	`else: # regular parameter`
`80`	`80`	`params.append(p)`
`81`	`81`
`82`		`- authn_params, _ = identify_required_authn_params(`
	`82`	`+ authn_params, used_auth_keys = identify_required_authn_params(`
`83`	`83`	`authn_params, auth_token_getters.keys()`
`84`	`84`	`)`
`85`	`85`
`@@ -97,9 +97,6 @@ def __parse_tool(`
`97`	`97`	`)`
`98`	`98`
`99`	`99`	`used_bound_keys = set(bound_params.keys())`
`100`		`- used_auth_keys: set[str] = set()`
`101`		`- for required_sources in authn_params.values():`
`102`		`- used_auth_keys.update(required_sources)`
`103`	`100`
`104`	`101`	`return tool, used_auth_keys, used_bound_keys`
`105`	`102`