Skip to content

Fix implementation of PosixFileAttributes.permissions() to return a modifiable set as specified in the Javadoc for that method. #416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 22, 2025
Merged

Fix implementation of PosixFileAttributes.permissions() to return a modifiable set as specified in the Javadoc for that method. #416

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions jimfs/src/main/java/com/google/common/jimfs/PosixAttributeProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
import java.nio.file.attribute.PosixFilePermission;
import java.nio.file.attribute.PosixFilePermissions;
import java.nio.file.attribute.UserPrincipal;
import java.util.LinkedHashSet;
import java.util.Map;
import java.util.Set;
import org.jspecify.annotations.Nullable;
Expand Down Expand Up @@ -68,7 +69,6 @@ public ImmutableSet<String> fixedAttributes() {
return ATTRIBUTES;
}

@SuppressWarnings("unchecked")
@Override
public ImmutableMap<String, ?> defaultValues(Map<String, ?> userProvidedDefaults) {
Object userProvidedGroup = userProvidedDefaults.get("posix:group");
Expand Down Expand Up @@ -262,8 +262,8 @@ public GroupPrincipal group() {
}

@Override
public ImmutableSet<PosixFilePermission> permissions() {
return permissions;
public Set<PosixFilePermission> permissions() {
return new LinkedHashSet<>(permissions);
}
}
}
7 changes: 7 additions & 0 deletions jimfs/src/test/java/com/google/common/jimfs/PosixAttributeProviderTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,4 +121,11 @@ public void testAttributes() {
assertThat(attrs.group()).isEqualTo(createGroupPrincipal("group"));
assertThat(attrs.fileKey()).isEqualTo(0);
}

@Test
public void testAttributes_permissionsAreModifiable() {
Set<PosixFilePermission> permissions = provider.readAttributes(file).permissions();
permissions.add(PosixFilePermission.OWNER_EXECUTE);
assertThat(permissions).isEqualTo(PosixFilePermissions.fromString("rwxr--r--"));
}
}
Loading