Model Batching V4 #231
Merged
Model Batching V4 #231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 9, 2025
Closed
Closed
btaba
reviewed
May 12, 2025
There was a problem hiding this comment.
Hi @adenzler-nvidia I'm not quite ready with the JAX shim to test, but I expect maybe by EOW. Nevertheless, I think this approach will work a lot better with JAX than prior versions, I can't foresee any big issues.
thowell
reviewed
May 12, 2025
thowell
reviewed
May 12, 2025
thowell
reviewed
May 12, 2025
|
@adenzler-nvidia thanks for making the updates to enable model batching for these fields! similar to @btaba i think this pr has a good selection of batched added a few minor comments for docstring formatting. thanks! |
erikfrey
approved these changes
May 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous discussions in #109 , another attempt in #195
@btaba could you help test-driving this from the JAX side once that's ready?