feat(EVMWalletClient): sendTransaction returns full transaction in response #497
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
What does this PR do?
Previously, waitForReceipt returned only a minimal object like { hash: "0x..." }. Since sendTransaction calls waitForReceipt and returns its result, this meant that the result of sendTransaction also only included the hash.
However, when I was extending ethers.Signer, there were methods that expected a full transaction receipt object with properties like to, from, hash, etc. When it tried to access something like tx["to"].concat(...), it failed because to was undefined, causing a runtime error.
This PR updates waitForReceipt to return the complete transaction receipt, ensuring sendTransaction passes back the full data structure
Testing
Detailed testing results
Checklist
If you require releasing a new version of the package:
pnpm change:addfrom thetypescriptdirectory