Skip to content

Refine mail templates #35150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Refine mail templates #35150

wants to merge 7 commits into from
+172 −138

Conversation

NorthRealm
Copy link
Contributor

  • Moved mail templates to new directories.
  • Added new devtest ymls.
  • Embedded styles possible.
  • Added New translation keys for actions email.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jul 23, 2025
@github-actions github-actions bot added modifies/translation modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files labels Jul 23, 2025
@lunny lunny added this to the 1.25.0 milestone Jul 23, 2025
delvh
delvh reviewed Jul 24, 2025
View reviewed changes
services/mailer/mail_repo.go
// SendCollaboratorMail sends mail notification to new collaborator.
func SendCollaboratorMail(u, doer *user_model.User, repo *repo_model.Repository) {
if setting.MailService == nil || !u.IsActive {
// No mail service configured OR the user is inactive
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// No mail service configured OR the user is inactive

@NorthRealm NorthRealm force-pushed the patch-mail-templates-1 branch from e1d2ca4 to 3ff5727 Compare July 24, 2025 12:04
@NorthRealm NorthRealm requested a review from delvh July 25, 2025 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delvh delvh Awaiting requested review from delvh

Assignees
No one assigned
Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files modifies/translation
Projects
None yet
Milestone
1.25.0
Development

Successfully merging this pull request may close these issues.
4 participants
@NorthRealm @delvh @lunny @GiteaBot